Skip to content

refactor: migrate MOCK_SETTINGS and mfe_config test overrides off FEATURES-as-dict #39018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
feanil wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −11
Open

refactor: migrate MOCK_SETTINGS and mfe_config test overrides off FEATURES-as-dict #39018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
141a04e
refactor: migrate DISABLE_SET_JWT_COOKIES_FOR_TESTS test override off…
feanil Aug 24, 2026
41019d2
refactor: migrate mfe_config precedence test off FEATURES-as-dict
feanil Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions common/djangoapps/student/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,19 +193,15 @@ class StudentDashboardTests(SharedModuleStoreTestCase, MilestonesTestCaseMixin,
ENABLED_SIGNALS = ['course_published']
MOCK_SETTINGS = {
'DISABLE_START_DATES': False,
'FEATURES': {
'DISABLE_SET_JWT_COOKIES_FOR_TESTS': True,
},
'DISABLE_SET_JWT_COOKIES_FOR_TESTS': True,
'SOCIAL_SHARING_SETTINGS': {
'CUSTOM_COURSE_URLS': True,
'DASHBOARD_FACEBOOK': True,
'DASHBOARD_TWITTER': True,
},
}
MOCK_SETTINGS_HIDE_COURSES = {
'FEATURES': {
'DISABLE_SET_JWT_COOKIES_FOR_TESTS': True,
}
'DISABLE_SET_JWT_COOKIES_FOR_TESTS': True,
}

def setUp(self):
Expand Down
9 changes: 4 additions & 5 deletions lms/djangoapps/mfe_config_api/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,11 +277,10 @@ def side_effect(key, default=None):
configuration_helpers_mock.get_value.side_effect = side_effect

with override_settings(
HOMEPAGE_COURSE_MAX=3, # Plain settings (lowest precedence)
FEATURES={ # Settings FEATURES
"ENABLE_COURSE_SORTING_BY_START_DATE": True,
"ENABLE_COURSE_DISCOVERY": True,
}
# Plain settings (lowest precedence)

@kdmccormick kdmccormick Sep 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Plain settings (lowest precedence)

I don't think this comment is meaningful without the FEATURES override

HOMEPAGE_COURSE_MAX=3,
ENABLE_COURSE_SORTING_BY_START_DATE=True,
ENABLE_COURSE_DISCOVERY=True,
):
response = self.client.get(f"{self.mfe_config_api_url}?mfe=catalog")

Expand Down
Loading