Repository navigation
fix(deps): resolve CI dependency audit failures - #394
Conversation
Update vulnerable transitive dependencies and scope js-yaml 4 to the NYC config loader to remove unpatched sprintf-js. Preserve dependency audits and the existing Jest and Monaco versions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Siddhant Khare <siddhantkhare2694@gmail.com>
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Note
Copilot was unable to run its full agentic suite in this review.
Copilot review overview
1 open finding
What changed in this PR
Adds and documents npm dependency overrides to keep CI security/audit checks passing, including pinning vulnerable transitive dependencies to patched versions.
Changes:
- Updated
package.jsonoverrides foraxios,dompurify, andjs-yaml(via@istanbuljs/load-nyc-config). - Documented the rationale and workflow for maintaining audit-related overrides in
README.md.
| File | Description |
|---|---|
| package.json | Adds/updates dependency overrides intended to satisfy CI/audit requirements. |
| README.md | Documents why overrides exist and how to validate them during dependency updates. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Keep the CI dependency remediation confined to the dependency manifests. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Siddhant Khare <siddhantkhare2694@gmail.com>

Root cause
The failing
testjobs on #392 , #393 stop atnpm audit --no-package-lock, before lint or Jest runs. The ESLint upgrade is not responsible: the same audit failure reproduces onmain.The manifest's Axios override pins a vulnerable release, and Jest's
@istanbuljs/load-nyc-configdependency pulls in unpatchedsprintf-jsthroughjs-yaml3 andargparse1. The committed lockfile also contains vulnerable patch versions of DOMPurify, brace-expansion, fast-uri, and Handlebars.Changes
js-yaml4.3.2 override to@istanbuljs/load-nyc-config, removing the vulnerablesprintf-jschain without downgrading Jest or changing Monaco.This is a standalone fix against
main; #392 remains the separate ESLint update.Validation
npm ci,npm audit, andnpm audit --no-package-lock: 0 vulnerabilities (previously 27 in the lockfile and 22 without it).extends, arrays, booleans, and option-name normalization with the overridden js-yaml version.