Skip to content

fix(deps): resolve CI dependency audit failures - #394

Merged
Siddhant-K-code merged 2 commits into
mainfrom
siddhant-k-code-ci-failure-fix
Oct 12, 2026
Merged

Siddhant-K-code merged 2 commits into
mainfrom
siddhant-k-code-ci-failure-fix

Conversation

@Siddhant-K-code

@Siddhant-K-code Siddhant-K-code commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Root cause

The failing test jobs on #392 , #393 stop at npm audit --no-package-lock, before lint or Jest runs. The ESLint upgrade is not responsible: the same audit failure reproduces on main.

The manifest's Axios override pins a vulnerable release, and Jest's @istanbuljs/load-nyc-config dependency pulls in unpatched sprintf-js through js-yaml 3 and argparse 1. The committed lockfile also contains vulnerable patch versions of DOMPurify, brace-expansion, fast-uri, and Handlebars.

Changes

  • Update the Axios override to 1.20.0 and the DOMPurify minimum to 3.4.16.
  • Scope a js-yaml 4.3.2 override to @istanbuljs/load-nyc-config, removing the vulnerable sprintf-js chain without downgrading Jest or changing Monaco.
  • Refresh only the affected transitive lockfile entries, preserving each brace-expansion major version.
  • CI's audit gate remains unchanged.

This is a standalone fix against main; #392 remains the separate ESLint update.

Validation

  • Clean npm ci, npm audit, and npm audit --no-package-lock: 0 vulnerabilities (previously 27 in the lockfile and 22 without it).
  • Circular dependency check, formatting, lint, TypeScript typecheck, and build pass. Lint also passes with ESLint 10.12.0 from chore(deps-dev): bump eslint from 10.11.0 to 10.12.0 #392; existing warnings are unchanged.
  • All 58 tests pass.
  • NYC YAML compatibility smoke check passes for extends, arrays, booleans, and option-name normalization with the overridden js-yaml version.

Update vulnerable transitive dependencies and scope js-yaml 4 to the NYC config loader to remove unpatched sprintf-js. Preserve dependency audits and the existing Jest and Monaco versions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Siddhant Khare <siddhantkhare2694@gmail.com>
@Siddhant-K-code
Siddhant-K-code requested review from a team as code owners October 12, 2026 12:11
Copilot AI balanced review requested due to automatic review settings October 12, 2026 12:11
@socket-security

socket-security Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Priority Alert  (click "▶" to expand/collapse) Action
Low priority
License policy violation: npm argparse under Python-2.0.1

License: Python-2.0.1 - The applicable license policy does not permit this license (5) (package/LICENSE)

From: package-lock.json → npm/jest@30.3.0 → npm/ts-jest@29.4.6 → npm/argparse@2.0.1

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/argparse@2.0.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn

View full report

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Copilot was unable to run its full agentic suite in this review.

Copilot review overview

1 open finding
What changed in this PR

Adds and documents npm dependency overrides to keep CI security/audit checks passing, including pinning vulnerable transitive dependencies to patched versions.

Changes:

  • Updated package.json overrides for axios, dompurify, and js-yaml (via @istanbuljs/load-nyc-config).
  • Documented the rationale and workflow for maintaining audit-related overrides in README.md.
File Description
package.json Adds/updates dependency overrides intended to satisfy CI/audit requirements.
README.md Documents why overrides exist and how to validate them during dependency updates.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md Outdated
SoulPancake
SoulPancake previously approved these changes Oct 12, 2026
Keep the CI dependency remediation confined to the dependency manifests.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Siddhant Khare <siddhantkhare2694@gmail.com>
@Siddhant-K-code
Siddhant-K-code added this pull request to the merge queue Oct 12, 2026
Merged via the queue into main with commit 6166e44 Oct 12, 2026
28 checks passed
@Siddhant-K-code
Siddhant-K-code deleted the siddhant-k-code-ci-failure-fix branch October 12, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants