Skip to content

site: type in the bottom bar - #20

Merged
ricardofrantz merged 4 commits into
mainfrom
site/footer-type
Nov 19, 2026
Merged

ricardofrantz merged 4 commits into
mainfrom
site/footer-type

Conversation

@ricardofrantz

@ricardofrantz ricardofrantz commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Built output of the machine-made site generator (see machine-made/machine-made.github.io, PR "site: type in the bottom bar", same title). docs/ is that generator's build for this site, byte for byte.

What changed

  • The footer now links all four names, machine-made · openfluids · BoringQuantSystems · type, with type pointing to https://machine-made.github.io/type/. Only docs/index.html and docs/style.css change.

Proof

  • Generator sh gate.sh: DETERMINISTIC, SELF-TEST OK (268 cases), OK, OK, OK, HOUSES OK, grep clean.
  • check_site.py --site on this site's build: OK.
  • docs/ matches the generator output: a file-by-file hash comparison against this branch finds 0 files to change and 0 to delete.
  • Screenshots checked (opened): of-1280.png, of-390.png.

@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Explain Change →

Walkthrough

The footer now links four site names. CSS adds wrapping, alignment, spacing, vertical padding, and a narrow-screen minimum-height rule for footer links.

Changes: Footer links and layout

Layer / File(s) Summary
Footer markup and styles
docs/index.html, docs/style.css
The footer links four site names. CSS makes the links wrap and align vertically, adds spacing and vertical padding, and applies the 44px minimum-height rule to footer links on narrow screens. The top-bar comment now also describes the footer links.

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Feature

Possibly related PRs

Merge Risk: Low · up to 8f22b

The footer now links all four site names. The links look like plain text, which may make them harder to spot on touch devices. This is a minor discoverability issue and does not block merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "site: type in the bottom bar" matches the change. The PR adds a footer link for the type site in docs/index.html and adds footer styling in docs/style.css. The title names the main change…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "site: type in the bottom bar" matches the change. The PR adds a footer link for the type site in docs/index.html and adds footer styling in docs/style.css. The title names the main change, the footer link for the type site. It is short and specific. It does not list every styling change, which is acceptable.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments: 1

docs/style.css-253-256: 1

253-256: Minor · Functional Correctness · Quick win

Unverified finding
Verification ran but could not confirm this finding. It is shown for review, not as a verified issue.

Make the footer links visibly identifiable.

The global a rule removes underlines, and these rules add no visible link cue. On a touch device, the footer names still appear as plain text, so users may not discover that they can open them. Add a persistent visual cue, such as an underline.

Review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2e7b4a6e-b1dd-4e95-8500-9b05c66dade5
Commits

Reviewing files that changed from the base of the PR and between 145071f and 8f22b38.

Files selected for processing: 2

  • docs/index.html
  • docs/style.css

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 2 files

Reply with feedback, questions, or to request a fix.

View guided diff | Re-trigger cubic

Comment thread docs/style.css Resolved
@ricardofrantz
ricardofrantz merged commit 6ccedee into main Nov 19, 2026
5 checks passed
@ricardofrantz
ricardofrantz deleted the site/footer-type branch November 19, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant