Repository navigation
ci(fuzz): install nightly by name and bring the fuzz lock file up to date - #1950
Conversation
…date The nightly Fuzz run has failed every night since the toolchain action's pin moved to its stable branch (#1530): the fuzz jobs got stable Rust, and cargo-fuzz's -Zsanitizer flag needs nightly. The job now asks for nightly by name, so the pin can stay where Dependabot keeps it. fuzz/Cargo.lock lacked subsetter and rustc-hash, which rustgis-render has needed since #1828, so the licence job's --locked check refused it.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Code reviewBugs: None found. I checked the lock file against the workspace manifests. Both Security: None found. The diff changes no executable code paths, only a CI toolchain selection and a lock file. Confidence: high. Performance: None found. Confidence: high. Quality:
AGENTS.md: No violations found. No new dependency is added to a manifest, so the licence check and Not verified: I could not run Inline comments: None posted. No finding met the bar for an inline comment. Prior reviews: The review-thread file is empty, so there were no earlier concerns to skip. Change sizeCompared with
|
📖 Docs preview
GitHub Pages takes a minute or two to publish a new commit. |
|
The workflow run by hand on this branch: https://github.com/opengeos/RustGIS/actions/runs/43475952194 (60 s a target). All nine targets now build on nightly and fuzz, and the licence and format job passes. Seven targets pass; |
Summary
The scheduled Fuzz workflow has failed every night since at least 8 November, from two causes, neither of them a fuzzing finding (so no issue was opened):
dtolnay/rust-toolchainpin in the fuzz job from the action'snightlybranch tob725eda, the commit of itsstablebranch that every other workflow pins; the# nightlycomment stayed. cargo-fuzz passes-Zsanitizer=address, so all nine targets stopped aterror: the option 'Z' is only accepted on the nightly compiler. The job now pins the same commit and asks fortoolchain: nightlyby name, so Dependabot can keep moving the pin without changing the toolchain.fuzz/Cargo.lockwas out of date.rustgis-renderhas depended onsubsetter(and through itrustc-hash) since feat(render): embed real fonts in a layout's vector PDF (#1815, part 1) #1828, and the fuzz crate's own lock file didn't list them, socargo deny --lockedin the "Fuzz crate licences and format" job refused it. The lock file gains those two packages; nothing else in it moves.Testing
main,cargo metadata --manifest-path fuzz/Cargo.toml --lockedfails withcannot update the lock file; on this branch it passes.cargo deny --manifest-path fuzz/Cargo.toml --locked check licenses sourcesgiveslicenses ok, sources ok, andcargo fmt --manifest-path fuzz/Cargo.toml --checkpasses.gh workflow run fuzz.yml --ref fix/fuzz-nightly-toolchain -f seconds=60) is the proof for the toolchain; its result is in a comment below.UI evidence
No visible UI change.
Related issue
None. Nothing checks
fuzz/Cargo.lockon a pull request, so it can go stale again when a workspace crate gains a dependency (it did before in #1754); a check for that is left out of this fix.Summary by CodeRabbit