Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
borosr
force-pushed
the
feat/v3-notification-events
branch
from
August 24, 2026 07:32
6075994 to
8855743
Compare
borosr
force-pushed
the
feat/v3-notification-events
branch
from
August 24, 2026 10:07
8855743 to
5778d95
Compare
borosr
force-pushed
the
feat/v3-notification-events
branch
from
August 24, 2026 10:55
5778d95 to
805caac
Compare
feat: wip chore: regenerate api clients and restore server notification wiring after rebase The rebase onto main resolved the generated artifacts with main's side, so they are regenerated here from the merged TypeSpec sources. The v3 server lost its notification handler wiring in the same resolution (main renamed the surrounding governance service to entitlement-access); the notification config field, validation, handler fields, and constructor wiring are restored on top of main's entitlement-access naming.
Replace the either-key-or-id subject/feature event filters with explicit subject_key, subject_id, feature_key and feature_id filters, and add general JSONB key predicate support to pkg/filter (SelectJSONB, ApplyToQueryJSONB) in place of the adapter-local annotation filter special-casing. The v1 handler maps its legacy repeated parameters onto the split filters by partitioning values on ULID validity.
borosr
force-pushed
the
feat/v3-notification-events
branch
from
September 7, 2026 13:39
703aab7 to
d988636
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
The PR introduces internal v3 APIs for listing, retrieving, filtering, and resending notification events.
Confidence Score: 5/5
The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope.
No blocking failure remains.
Important Files Changed
Sequence Diagram
sequenceDiagram participant Client participant API as Notification Events API participant Service as Notification Service participant DB as Event Repository participant Worker as Reconciliation Worker participant Webhook Client->>API: GET /notification/events API->>Service: ListEvents(filters) Service->>DB: Query namespaced events DB-->>Service: Events and delivery statuses Service-->>API: Domain events API-->>Client: v3 event representations Client->>API: "POST /notification/events/{id}/resend" API->>Service: ResendEvent(event, channels) Service->>DB: Mark eligible statuses RESENDING API-->>Client: 202 Accepted Worker->>DB: Poll pending/resending events Worker->>Webhook: Re-send delivery Webhook-->>Worker: Delivery result Worker->>DB: Update delivery statusReviews (6): Last reviewed commit: "fix: resolve notification type format to..." | Re-trigger Greptile