Skip to content

ADD: Support for terrain using the immersed boundary condition - #174

Merged
rcjackson merged 3 commits into
openradar:mainfrom
rcjackson:terrain-immersed-boundary
Nov 11, 2026
Merged

rcjackson merged 3 commits into
openradar:mainfrom
rcjackson:terrain-immersed-boundary

Conversation

@rcjackson

Copy link
Copy Markdown
Collaborator

This adds support for terrain as a lower boundary condition, forcing the dot product of u with the normal of the terrain to be 0 as has been done in numerous papers (i.e. Cha and Bell (2023)).

Based on:
Cha, T., and M. M. Bell, 2023: Three-Dimensional Variational Multi-Doppler Wind Retrieval over Complex Terrain. J. Atmos. Oceanic Technol., 40, 1381–1405, https://doi.org/10.1175/JTECH-D-23-0019.1.

Used Codex and GPT5.6-Luna for assistance.

@codecov

codecov Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.83784% with 18 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.31%. Comparing base (d62348d) to head (a7431f9).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pydda/terrain.py 81.44% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #174      +/-   ##
==========================================
+ Coverage   70.42%   71.31%   +0.88%     
==========================================
  Files          32       34       +2     
  Lines        5856     6013     +157     
==========================================
+ Hits         4124     4288     +164     
+ Misses       1732     1725       -7     
Flag Coverage Δ
unittests 71.31% <87.83%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rcjackson
rcjackson merged commit 04c409b into openradar:main Nov 11, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant