Repository navigation
Clarify datapoint retention docs to match purge behaviour - #3442
Merged
Merged
Conversation
The DATA_POINTS_MAX_AGE_DAYS javadoc stated the meta item has no effect, but the purge still uses its largest value across all attributes as a minimum for the global retention period. Update the javadoc to describe this, and update the deploy.yml comment and README to document OR_DATA_POINTS_MAX_AGE_WEEKS and the infinite default retention. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
wborn
requested changes
Oct 19, 2026
wborn
left a comment
wborn
left a comment
Member
There was a problem hiding this comment.
This is an initial AI-assisted review.
The updated retention documentation matches the current implementation, including the global week-based configuration, the deprecated fallback, and the effect of legacy attribute retention settings.
One Javadoc inconsistency remains: the original description of DATA_POINTS_MAX_AGE_DAYS still implies per-attribute purging, contradicting the updated deprecation explanation.
Updated deprecation comment for STORE_DATA_POINTS to clarify changes in retention policy.
Member
Author
|
Updated @wborn |
|
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2352. The
DATA_POINTS_MAX_AGE_DAYS(dataPointsMaxAgeDays) javadoc said the meta item "has no effect", butAssetDatapointService.purgeDataPoints()still uses its largest value across all attributes (rounded up to weeks) as a minimum for the global retention period. Following the review discussion on #2352 (drop chunks only once they are older than the longest retention), this keeps that behaviour and fixes the documentation to match.Changes
MetaItemType: deprecation javadoc now describes the actual behaviour. The meta item can only extend retention, for all attributes, and has no effect when purging is disabled.profile/deploy.yml: the comment documentsOR_DATA_POINTS_MAX_AGE_WEEKS, the infinite default and the deprecatedOR_DATA_POINTS_MAX_AGE_DAYSfallback.README.md: updated the outdated "purged daily" sentence.AssetDatapointService: fixed a typo in the class javadoc.No behavioural changes.
Related docs issue: openremote/documentation#165