Pass cursor to wrapped visitors in UpgradeTransitiveDependencyVersion - #201
Merged
Merged
Conversation
Lets the Gradle visitor reach the cycle's root cursor, so caches stored on cursor.getRoot() are shared across files instead of reset per file.
timtebeek
deleted the
tim/upgradetransitivedependencyversion-cursor-fix
branch
October 1, 2026 17:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delegating visitor in
UpgradeTransitiveDependencyVersionnow callsvisitNonNull(t, ctx, getCursor())on the Gradle and Maven visitors it wraps, so they run under the recipe cycle's root cursor instead of a fresh root per file. openrewrite/rewrite is moving rewrite-gradle's parsed-snippet cache from the ExecutionContext ontocursor.getRoot(); without this, that cache would only last a single file and every file would reparse the Gradle snippets. No behavior change, only avoids repeated (slow) GradleParser work.