Emit @lombok.CheckReturnValue on Lombok-generated methods - #9012
Merged
Merged
Conversation
timtebeek
changed the title
@lombok.CheckReturnValue on Lombok-generated methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
lombok.checkReturnValueAnnotation = lombok(new in Lombok 1.18.48), so generated getters, withers,build(),toString,equalsandhashCodecarry@lombok.CheckReturnValue. IntelliJ, Error Prone and SpotBugs then warn when a result is discarded, such as atree.withPrefix(..)whose result is never assigned, including in downstream recipe modules. A bytecode scan of all main and test classes found no such ignored calls; the only five hits are deliberate "does not throw" checks in tests. The annotation has CLASS retention, and consumers compile cleanly with-Xlint:all -Werroreven without Lombok on their classpath.