Skip to content

SRVKP-14135: Show restricted access instead of loading on PipelineRuns RBAC error - #1407

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-pipelines:masterfrom
ankrsinha:fix/SRVKP-14135
Oct 5, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift-pipelines:masterfrom
ankrsinha:fix/SRVKP-14135

Conversation

@ankrsinha

Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix
  • New feature
  • Refactoring
  • Migration
  • CVE Fix

Summary

Fixes the Approvals tab remaining in a loading state when the dependent PipelineRuns request fails due to insufficient RBAC.
The PipelineRuns load error is now passed to the existing shared data view along with the ApprovalTasks error, allowing the standard Restricted access panel to be displayed instead of an indefinite loading skeleton.

Screen Recordings / Screenshot

Before fix

SRVKP-14135-before-fix.mp4

After fix

SRVKP-14135-after-fix.mp4

…rror

Signed-off-by: Ankur Sinha <anksinha@redhat.com>
@openshift-ci-robot

openshift-ci-robot commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

@ankrsinha: This pull request references SRVKP-14135 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Type of Change

  • Bug fix
  • New feature
  • Refactoring
  • Migration
  • CVE Fix

Summary

Fixes the Approvals tab remaining in a loading state when the dependent PipelineRuns request fails due to insufficient RBAC.
The PipelineRuns load error is now passed to the existing shared data view along with the ApprovalTasks error, allowing the standard Restricted access panel to be displayed instead of an indefinite loading skeleton.

Screen Recordings / Screenshot

Before fix

SRVKP-14135-before-fix.mp4

After fix

SRVKP-14135-after-fix.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qodo-code-review

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Warning

/review is deprecated. Use /agentic_review instead (removal date not yet scheduled).

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

@qodo-code-review

Copy link
Copy Markdown

Important

The /generate_labels command by Qodo is sunsetting on the 1st of October 2026 and will no longer be available. We recommend switching to the latest Qodo review capabilities. Learn more

@anwesha-palit-redhat anwesha-palit-redhat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankrsinha, anwesha-palit-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [anwesha-palit-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added lgtm Looks Good to Me Label approved Label for Approved PRs labels Oct 5, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 7616322 into openshift-pipelines:master Oct 5, 2026
7 of 8 checks passed
@ankrsinha

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-v1.24.x

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@ankrsinha: new pull request created: #1423

Details

In response to this:

/cherry-pick release-v1.24.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Label for Approved PRs Bug fix jira/valid-reference lgtm Looks Good to Me Label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants