Repository navigation
SRVKP-14135: Show restricted access instead of loading on PipelineRuns RBAC error - #1407
Conversation
…rror Signed-off-by: Ankur Sinha <anksinha@redhat.com>
|
@ankrsinha: This pull request references SRVKP-14135 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
PR Reviewer Guide 🔍Warning
Here are some key observations to aid the review process:
|
|
Important The |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankrsinha, anwesha-palit-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7616322
into
openshift-pipelines:master
|
/cherry-pick release-v1.24.x |
|
@ankrsinha: new pull request created: #1423 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Type of Change
Summary
Fixes the Approvals tab remaining in a loading state when the dependent PipelineRuns request fails due to insufficient RBAC.
The PipelineRuns load error is now passed to the existing shared data view along with the ApprovalTasks error, allowing the standard Restricted access panel to be displayed instead of an indefinite loading skeleton.
Screen Recordings / Screenshot
Before fix
SRVKP-14135-before-fix.mp4
After fix
SRVKP-14135-after-fix.mp4