fix: Use proper token issued_at time - #1194
Merged
Merged
Conversation
python keystone extracts 'issued_at' of the fernet token from the fernet creation timestamp. Our code does this as well, but in the token creation it fetches the date of the token which didn't go the serialization/deserialization, so the time is default. Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
Error Metrics
|
|
🧪 Tempest Identity Compatibility Results (advisory, non-blocking) rust Failed test IDs |
|
| Project | keystone |
| Branch | token_issued_at |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Command_Serde/apply/remove | 📈 view plot 🚷 view threshold | 101,300.00 ns(-64.83%)Baseline: 287,998.08 ns | 1,572,400.69 ns (6.44%) |
| Command_Serde/apply/set | 📈 view plot 🚷 view threshold | 100,680.00 ns(-65.08%)Baseline: 288,278.77 ns | 1,310,354.29 ns (7.68%) |
| Command_Serde/pack/delete | 📈 view plot 🚷 view threshold | 128.20 ns(+7.73%)Baseline: 119.01 ns | 155.43 ns (82.48%) |
| Command_Serde/pack/delete_index | 📈 view plot 🚷 view threshold | 115.25 ns(+8.53%)Baseline: 106.19 ns | 138.71 ns (83.09%) |
| Command_Serde/pack/set | 📈 view plot 🚷 view threshold | 203.34 ns(+6.76%)Baseline: 190.47 ns | 245.98 ns (82.66%) |
| Command_Serde/pack/set_index | 📈 view plot 🚷 view threshold | 116.94 ns(+10.09%)Baseline: 106.22 ns | 139.21 ns (84.00%) |
| Command_Serde/unpack/delete | 📈 view plot 🚷 view threshold | 221.65 ns(+17.11%)Baseline: 189.27 ns | 268.71 ns (82.49%) |
| Command_Serde/unpack/delete_index | 📈 view plot 🚷 view threshold | 177.87 ns(+13.20%)Baseline: 157.13 ns | 217.58 ns (81.75%) |
| Command_Serde/unpack/set | 📈 view plot 🚷 view threshold | 279.53 ns(+7.06%)Baseline: 261.10 ns | 350.82 ns (79.68%) |
| Command_Serde/unpack/set_index | 📈 view plot 🚷 view threshold | 179.14 ns(+15.88%)Baseline: 154.59 ns | 211.52 ns (84.69%) |
| Payload_encryption/pack/remove_cmd | 📈 view plot 🚷 view threshold | 118.36 ns(+4.16%)Baseline: 113.63 ns | 148.10 ns (79.92%) |
| Payload_encryption/pack/set_cmd | 📈 view plot 🚷 view threshold | 192.11 ns(-2.89%)Baseline: 197.83 ns | 260.13 ns (73.85%) |
| Payload_encryption/unpack/remove_cmd | 📈 view plot 🚷 view threshold | 227.27 ns(+14.98%)Baseline: 197.66 ns | 280.16 ns (81.12%) |
| Payload_encryption/unpack/set_cmd | 📈 view plot 🚷 view threshold | 273.59 ns(+0.74%)Baseline: 271.59 ns | 370.27 ns (73.89%) |
| Raft_1Node_Latency/prefix/1node | 📈 view plot 🚷 view threshold | 5,008,000.00 ns(+62.64%)Baseline: 3,079,175.62 ns | 7,959,386.93 ns (62.92%) |
| Raft_1Node_Latency/read/1node | 📈 view plot 🚷 view threshold | 35,264.00 ns(-5.36%)Baseline: 37,260.84 ns | 51,571.41 ns (68.38%) |
| Raft_1Node_Latency/remove/1node | 📈 view plot 🚷 view threshold | 277,470.00 ns(-61.06%)Baseline: 712,576.72 ns | 3,688,598.31 ns (7.52%) |
| Raft_1Node_Latency/write/1node | 📈 view plot 🚷 view threshold | 297,450.00 ns(-61.75%)Baseline: 777,739.84 ns | 4,699,700.27 ns (6.33%) |
| build_snapshot/default | 📈 view plot 🚷 view threshold | 103,800.00 ns(-13.98%)Baseline: 120,664.89 ns | 206,754.18 ns (50.20%) |
| fernet token/project | 📈 view plot 🚷 view threshold | 1,528.90 ns(+6.46%)Baseline: 1,436.16 ns | 1,798.62 ns (85.00%) |
| get_data_keyspace | 📈 view plot 🚷 view threshold | 0.35 ns(+11.19%)Baseline: 0.32 ns | 0.39 ns (90.80%) |
| get_db | 📈 view plot 🚷 view threshold | 0.35 ns(+10.88%)Baseline: 0.32 ns | 0.39 ns (90.46%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 146.47 ns(+4.82%)Baseline: 139.73 ns | 178.35 ns (82.12%) |
| get_keyspace | 📈 view plot 🚷 view threshold | 4.72 ns(-18.50%)Baseline: 5.79 ns | 13.50 ns (34.98%) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python keystone extracts 'issued_at' of the fernet token from the fernet
creation timestamp. Our code does this as well, but in the token
creation it fetches the date of the token which didn't go the
serialization/deserialization, so the time is default.
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com