Repository navigation
ci(verify-release): verify the latest release nightly, and resolve an empty tag instead of guessing - #58
Merged
Conversation
…mpty tag instead of guessing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps left after #54/#57:
workflow_runtrigger proves "the thing released a minute ago is fine"; a broken page, a Pages drift or a key rotation is only caught if someone runs the workflow by hand. It now also runs onschedule: 17 3 * * *(UTC) against the current latest release.TAGused to be fatal, and before that it silently verified whateverghconsidered latest. Ascheduleevent carries no tag at all, so aresolve the tagstep now falls back togh release view --json tagNameand exports the resolved value; only if that also fails does the job go red.Also changelogged the three CI false-reds found today (SIGPIPE on
grep -q, the byte comparison judged from one transientapt-get download, the empty tag underworkflow_run).I could not exercise the manual dispatch to confirm #57 on
v0.2.8: the UI dialog's POST to/actions/manualreturns 422 with the CSRF header supplied, so the first proof of the new logic is the nightly run (or the next release). What I did check locally: the signed index'sSHA256for0.2.8equals the release checksum.