Skip to content

feat(release): say what changed in the notes; verify a download with one command - #59

Merged
openviewmobile merged 1 commit into
mainfrom
feat/release-notes-and-verify
Nov 10, 2026
Merged

openviewmobile merged 1 commit into
mainfrom
feat/release-notes-and-verify

Conversation

@openviewmobile

Copy link
Copy Markdown
Owner

Two gaps that both sit between "it works" and "a user can confirm it works".

1. The release notes never said what changed. The body was a fixed template (asset table + signing notes) — a reader had to open CHANGELOG.md or the commit list. publish now runs scripts/changelog_section.py <version> and puts the matching CHANGELOG.md section at the top, above the asset table. If the section is missing it emits a ::warning:: and ships the old body: a release that fails to publish is worse than one with a shorter description.

Verified locally: for 0.2.8 the section is extracted and concatenated in the right order; for 9.9.9 the warning branch fires with CHANGELOG.md 里没有 [9.9.9] 这一节.

2. Verifying a download needed four hand-assembled commands. scripts/verify_download.sh <dir> [tag] builds a throwaway keyring from the key published on the site (never the signing key), verifies SHA256SUMS.txt.asc, re-hashes whichever assets are present, then verifies the .deb detached signature and the .rpm embedded one; a missing rpm prints 跳过 instead of pretending.

Exercised against the real v0.2.7 assets:

✓ SHA256SUMS.txt 的签名有效(签名者 9E85497E64A128A1427CD5F8AEF0C14A16617FE8)
✓ 3 个文件的 sha256 与签名过的清单一致(9 个清单条目本目录没有,跳过)
✓ deb 的分离签名有效
· 没装 rpm,跳过 rpm 嵌入签名

and the negative case (one byte appended to the .deb): ✗ synhub_0.2.7_amd64.deb 的 sha256 与 SHA256SUMS.txt 不一致.

One trap worth recording: $signer) with a full-width parenthesis right after the variable made bash read the CJK bytes as part of the name (signer: unbound variable) — ${signer} from now on.

…download.sh checks a download in one command
@openviewmobile
openviewmobile merged commit f7271d2 into main Nov 10, 2026
2 checks passed
@openviewmobile
openviewmobile deleted the feat/release-notes-and-verify branch November 10, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant