Repository navigation
feat(release): say what changed in the notes; verify a download with one command - #59
Merged
Merged
Conversation
…download.sh checks a download in one command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two gaps that both sit between "it works" and "a user can confirm it works".
1. The release notes never said what changed. The body was a fixed template (asset table + signing notes) — a reader had to open
CHANGELOG.mdor the commit list.publishnow runsscripts/changelog_section.py <version>and puts the matchingCHANGELOG.mdsection at the top, above the asset table. If the section is missing it emits a::warning::and ships the old body: a release that fails to publish is worse than one with a shorter description.Verified locally: for
0.2.8the section is extracted and concatenated in the right order; for9.9.9the warning branch fires withCHANGELOG.md 里没有 [9.9.9] 这一节.2. Verifying a download needed four hand-assembled commands.
scripts/verify_download.sh <dir> [tag]builds a throwaway keyring from the key published on the site (never the signing key), verifiesSHA256SUMS.txt.asc, re-hashes whichever assets are present, then verifies the.debdetached signature and the.rpmembedded one; a missingrpmprints跳过instead of pretending.Exercised against the real
v0.2.7assets:and the negative case (one byte appended to the
.deb):✗ synhub_0.2.7_amd64.deb 的 sha256 与 SHA256SUMS.txt 不一致.One trap worth recording:
$signer)with a full-width parenthesis right after the variable made bash read the CJK bytes as part of the name (signer: unbound variable) —${signer}from now on.