Repository navigation
fix(verify-release): the tag does not cross jobs — resolve it in each one - #60
Merged
Merged
Conversation
…jobs); assert the expected version is non-empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first nightly run failed with a message that blamed the wrong thing:
The expected value was empty.
resolve the tagwritesTAGthrough$GITHUB_ENV, which only applies to the job that wrote it; therepositoriesjob never had a tag, and on ascheduleevent there is no event-supplied tag either. So the wait loop compared0.2.8against""and, after twelve minutes, reported the site as lagging — the site was fine all along (Version: 0.2.8,SHA256: 8081afcd…).Both jobs now resolve the tag themselves, and the wait step first asserts that the expected version is non-empty, so this failure can never again masquerade as a repository problem.
Note the
artifactsjob passed all along (its own resolution worked), so the signature half of the nightly was already green — including rpm under 4.18 and 4.20 with the published key.