Fix the test student nav to show all versions of tests. (hotfix of #3177) - #3178
Fix the test student nav to show all versions of tests. (hotfix of #3177)#3178drgrice1 wants to merge 1 commit into
Conversation
|
This definitely needs to be merged before instructors start grading tests this term! |
87ff9ed to
e2e0216
Compare
|
I want to point out that the code in develop is quite wrong. For example, assume that you have assigned a test that allows students to take at least 2 attempts, and there are two students that have taken the test. Say that student1 has taken 2 attempts, but student2 has taken only one attempt. Then the student nav will list student1's first version, but not the second version, and will list student2 with version 2, but will not even list student2's actual only version. If you click on the link for student2, version2 it will give you |
|
So yes, I really dropped the ball in that rework of the test student nav. |
In the rework of the test student nav there was a flaw in design that led to only one version of a test being shown for each student. It is not the right thing to iterate over the users For which a test version exists. Instead the actual test versions need to be iterated over. The users are looked up in a hash in that loop.
e2e0216 to
b0f01a7
Compare
2 participants
In the rework of the test student nav there was a flaw in design that led to only one version of a test being shown for each student. It is not the right thing to iterate over the users For which a test version exists. Instead the actual test versions need to be iterated over. The users are looked up in a hash in that loop.