Skip to content

feat(fork): turn the area right of the thread list into a work area of split panes - #216

Open
orbitingflea wants to merge 1 commit into
mainfrom
proto/fullscreen-panels
Open

orbitingflea wants to merge 1 commit into
mainfrom
proto/fullscreen-panels

Conversation

@orbitingflea

@orbitingflea orbitingflea commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

This pull request turns the area right of the thread list into one work area of split panes, with the chat as one tab kind. It is a live-test prototype for one host, not ready to merge.

改了什么行为

Behaviour change: yes, web and desktop users see one work area of split panes with the chat as one kind of tab instead of a chat with a right panel.

Links open beside their chat. Pull request, issue, and web links in another thread's file tab open beside that file in the layout that shows it. Thread links to another project or environment open that thread's page. Toggling preview, diff, or a terminal with the Chat hidden, or floating a browser or device, hides the tab and keeps its session. Floated browsers and devices show in the floating player. Panes with a message box are at least 360 px wide. Subagents and side chats use upstream's tabs.

Why

The owner asked for an area that splits like editor windows. After a design review of the prototype, this round hides tabs instead of deleting them, puts tab rules in one table, navigates on other-project links, uses upstream's tabs for subagents, and trims upstream edits.

Checks

  • Unit and browser tests cover layout, placement, widths, hidden tabs, reply tabs, drags, and links.
  • Changed-file checks pass. A few browser test files time out only in the parallel run and pass alone.
  • A check in the real web app covered desktop and phone widths.

How to undo

Revert the commit. There is no server or database change.

Design notes
  • Drag a tab to an edge to split. Fast one-move drags drop. Closing a pane's last tab removes it. Closing several focuses the nearest. A lone pane has Split right for a New tab.
  • Pull request, issue, commit, web, and Dashboard links from chat show an open tab, split a lone pane right, or pick the nearest other pane, non-Chat first in right, left, down, up order. In a foreign Chat or side chat, commit links open the pull request or link, not Diff, which shows that thread's commit. Whiteboard chips and board:// links open their region. A pane's + menu lands its tab there even if focus moves first.
  • Each Replies sub-thread is a tab with its own draft. Replies from the list beside Chat open next to it. Cites with no reply draft go to the main box. A Find step in a sub-thread keeps the Find field and never covers its chat. A quote link shows the reply tab beside its chat when room fits, else over it, in strip view too, and focuses it. Both replace the last revealed reply tab unless taken over by a press in it, pane focus, drag, Replies open, or draft.
  • Toggling again, "Open in right panel", or Reopen Closed View restores hidden tabs. With Chat hidden, terminal split and close act on the focused terminal tab, and terminal toggle hides the focused one then restores it next press. Agent browsers float like upstream. Hidden tabs stay hidden on updates. Closing the player or reload restores them as background tabs.
  • Automatic opens, like tool diffs, never cover message-box tabs: Chat, reply, side-chat, and subagent.
  • Same-project thread drags open a Chat tab. Other-project drags do nothing. Saved foreign Chat tabs show "Open thread". Cmd or Ctrl click, middle click, and "Open in main view" navigate like upstream.
  • The chat header drops the terminal button, top band, and "New thread in project" since the project name is plain text as asked. Details sits on the tab bar right. Thread-list new-thread buttons stay.
  • Each right-panel record adds workArea, a pane-and-tab tree. Store writes reconcile tabs, drop empty panes, and keep one Chat. A storage version bump keeps the layout without hidden tabs.
  • One table holds tab rules, including side threads. Opens carry their source tab across lookups. Sourceless opens keep old placement.
  • Ratio writes keep the 360 px floor. When tight, splits widen or the tab joins its source pane. Unfit saved layouts show as a strip.
  • Fork code is in apps/web/src/fork/, with hooks in about 39 upstream files. Fork strings are English only.

Known limits:

  • A browser from a chat or file link may briefly show as a background tab in another pane before moving beside its source.
  • A hidden terminal or Diff restored by its toggle lands by the open rule, not in its old pane.
  • A main-Chat open with no other source, like a subagent click, may cover a side chat.
  • A side thread's tool diff opens beside main Chat.
  • Saved layouts with a side chat under 360 px show as a strip until it moves or closes.
  • Linked-machine thread links open upstream's read-only view in a pane.

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XL labels Nov 19, 2026
@github-actions

github-actions Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

This PR changes the test suite by +104 test cases (browser +20, unit +84, server 0).

New browser test files: apps/web/src/fork/subThreads/subThreadFind.browser.test.tsx, apps/web/src/fork/workArea/WorkArea.browser.test.tsx, apps/web/src/fork/workArea/changeRequestLink.browser.test.tsx.
Each browser test file costs CI seconds of module loading before its first test runs; a unit test costs milliseconds.

Keep tests that would fail for a real reason, and test logic below the UI where it can be. See Testing.

@orbitingflea
orbitingflea force-pushed the proto/fullscreen-panels branch from 377fc32 to 547954f Compare November 20, 2026 00:43
@orbitingflea orbitingflea changed the title feat(fork): make the chat a tab of the maximized right panel feat(fork): turn the area right of the thread list into a work area of split panes Nov 20, 2026
@github-actions github-actions Bot added size:XXL and removed size:XL labels Nov 20, 2026
@orbitingflea
orbitingflea force-pushed the proto/fullscreen-panels branch 2 times, most recently from 05fe5d0 to 66e542e Compare November 20, 2026 02:26
@github-actions

github-actions Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for 740fc65.

This comment will update automatically after the next completed run.

@orbitingflea
orbitingflea force-pushed the proto/fullscreen-panels branch 9 times, most recently from 94ab4d1 to 740fc65 Compare November 22, 2026 07:55
…f split panes

Everything right of the thread list is one work area of nested panes, and
the chat is one kind of tab in it. Dragging a tab onto an edge of a pane
splits that pane; closing a pane's last tab closes the pane. Dragging a
thread of the same project from the thread list into the area opens its
chat as another Chat tab, whose file links open that thread's files. The
last Chat tab cannot close. Each thread keeps its own layout in its
right-panel record, and the right panel's show, hide and maximize
controls are gone.

A tab opened from a chat or a linked file shows a tab already open, or
splits a lone pane to the right, or else lands in the nearest other pane,
preferring one not showing a Chat, looking right, left, down, then up.
A whiteboard chip in the composer and a board:// link in a chat show the
region on the Whiteboard and never open a file.

A pane holding a chat, reply or side-thread box is at least 360 px wide,
and automatic opens never cover a reply or side-thread tab. The chat
header loses its terminal button and the band above it, and its details
toggle sits at the right end of the pane's tab bar. A lone pane has a
Split right button that opens a New tab launcher beside it. A thread link
of the same project opens that thread as a Chat tab by the same rule; a
thread of another project or environment opens on its own page.
Subagents and side chats use upstream's side-thread tabs. Each Replies
sub-thread opens as its own tab with its own draft. A quote link shows
its reply tab; a Find step keeps the Find field and never covers its
chat. Both reuse the reply tab the last reveal opened until the user
takes it over.

Preview: Toggle, picture-in-picture and device Float hide a tab into the
floating player and keep its session; a session update no longer brings
a hidden browser back, and toggling again or Open in panel docks it. The
Diff toggle, and the terminal toggle while the chat is hidden, hide and
reopen their tab; the terminal toggle acts on the focused terminal and
brings back the one it hid. A tab picked from a pane's + menu lands in
that pane, and a browser opened from a link lands beside its source even
when the session list adds it first. Reopen Closed View reopens a view
whose tab is hidden. Agent-opened browsers float as upstream does.
Upstream files carry only small hooks; the preview, device, settings and
translation files are upstream's again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@orbitingflea
orbitingflea force-pushed the proto/fullscreen-panels branch from 740fc65 to 8805261 Compare November 22, 2026 09:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant