Revert "Require remaining osac CI checks in merge gate" - #206
Conversation
This reverts commit c327960.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe ChangesOSAC merge queue configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized change reverts the additional required CI checks, and no actionable merge-blocking risk remains based on the supplied evidence. Suggested labels: 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. Full details: No-Hardcoded-SecretsExplanation PASS: The pull request changes only Full details: No-Weak-CryptoExplanation PASS. The pull request changes only Full details: No-Injection-VectorsExplanation PASS. The pull request changes only Full details: Container-PrivilegesExplanation PASS. The pull request changes only Full details: No-Sensitive-Data-In-LogsExplanation PASS — The pull request changes only Full details: Ai-AttributionExplanation PASS: The PR description and the sole PR commit mention no AI tool. The commit has no Co-Authored-By, Assisted-by, or Generated-by trailer. The parent commit contains an old ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
## Summary - Resubmit of #205 after #206 revert, now that [osac-project/osac#717](osac-project/osac#717) is merged - Add remaining cheap osac CI jobs to `repo_osac` merge-queue required checks - Covers ansible-lint, FS python/go/binaries, helm CRD sync, installer helm lint, darwin keychain, operator/BMF unit tests, metering generated-code, dependency-review - Step skip still reports success, so unrelated PRs are not blocked osac#717 makes those workflows always report these names on `pull_request`/`merge_group`. Applying this ruleset before that left the merge queue waiting for checks that never started. ## Jira N/A ## Test plan - [x] osac#717 merged - [ ] Context names match osac GitHub Actions job `name:` (or job id if unnamed) - [ ] Docs-only / unrelated-component PRs still merge (names report, work skipped) --- _This PR description was drafted with AI assistance ([create-pr](https://github.com/osac-project/osac-workspace/tree/main/skills/create-pr) v0.1.3). Review for accuracy_ Signed-off-by: Min Zhang <minzhang@redhat.com>
Reverts #205
Summary
osacrepository merge queue. The merge gate now requires only the remaining integration-test, pre-commit, and generated-code checks.Backward compatibility
This change affects merge-gate enforcement only. It does not change runtime behavior, APIs, deployed resources, or stored data. It reduces CI protection because 12 checks are no longer required for merging.
Risk classification
risk:ship — Configuration-only change with no runtime, API, deployment, database, or security impact. It is close to risk:show because it weakens required CI checks, but it does not alter application behavior or production systems.