fix: check both formatters in the test recipe - #513
Merged
Merged
Conversation
just test verified justfile formatting only. Markdown and the docs site were covered by CI alone, which is enough for an ordinary pull request but not for a fix merged from a security advisory's private fork: those forks run no Actions, so this recipe is the only gate such a change gets before it reaches main. Three advisory fixes each edited pages under docs/ and left five of them unformatted, so Docusaurus Lint failed on main from a48daff until #512. Both checks now run here, where they would have caught it. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
md-fmt-check runs mdformat through uvx, and the Go workflow installs Go, Node, bun and just but not uv, so just test failed with uvx: not found. Markdown Lint already runs that check in a job that installs uv. docusaurus-fmt-check stays: bun is installed in the Go workflow and the recipe installs the site dependencies itself, and that is the check whose absence let five unformatted pages reach main. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #513 +/- ##
=======================================
Coverage 99.90% 99.90%
=======================================
Files 489 489
Lines 23174 23174
=======================================
Hits 23153 23153
Misses 21 21 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just testchecked justfile formatting only. Markdown and the Docusaurus site were covered by CI alone.That is fine for an ordinary pull request —
Markdown LintandDocusaurus Lintboth run onpull_request. It is not fine for a fix merged from a security advisory's private fork: those forks run no Actions at all (GET /repos/osapi-io/osapi-ghsa-…/actions/runsreturns 404), so the fix's first CI run happens on main, after the merge. For those changes this recipe is the only pre-merge gate.Three advisory fixes each edited a page under
docs/and left five unformatted, soDocusaurus Lintfailed on main froma48daffe8until #512.testnow runsmd-fmt-checkanddocusaurus-fmt-checkalongsidejust-fmt-check, with a comment saying why. Both pass on current main.🤖 Generated with Claude Code
https://claude.ai/code/session_01FuKUsHFG1EqZXamffh9M2c