Repository navigation
Potential fix for code scanning alert no. 2: DOM text reinterpreted as HTML - #776
Merged
Merged
Conversation
…s HTML Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/oss-apps/split-pro/security/code-scanning/2
Use safe URL/query construction instead of manual string interpolation.
Best fix: build the redirect with
URLSearchParams(orURL) so each dynamic value is encoded contextually and cannot break query boundaries.In
src/pages/auth/VerificationStep.tsx, updateonOTPSubmit(lines 35–44 region):otponce from the form.const params = new URLSearchParams({ email, token: otp }).callbackUrlexists, append it usingparams.append('callbackUrl', callbackUrl).window.location.hrefto`/api/auth/callback/email?${params.toString()}`.This preserves behavior while removing unsafe concatenation and encoding all untrusted data properly.
No new imports are required.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.