Repository navigation
ci: bump mise-action to v5.2.8 and fix smoke test index.html check - #1
Merged
Merged
Conversation
jdx/mise-action@v3.6.3 targets Node 20, which GitHub has deprecated and now forces onto Node 24 with a warning annotation on every job. Bump to the verified v5.2.8 commit, which runs on Node 24 natively. No call site here passes any mise-action input, so this is a pure pin bump. scripts/smoke-test-image.sh asserted 200 for GET /index.html, but the public handler serves the embedded SPA through http.FileServerFS, which unconditionally redirects any request ending in /index.html to / with a 301. That is correct, standard net/http behaviour, not a defect in the handler, so the script's expectation was the wrong side to fix. Signed-off-by: Simon Ostendorf <github@simon-ostendorf.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
jdx/mise-actionpin from v3.6.3 to the verified v5.2.8 commit.scripts/smoke-test-image.shto expect a 301, not 200, forGET /index.html.Why
GitHub has deprecated Node 20 and is forcing every job pinned to
jdx/mise-action@v3.6.3onto Node 24 with a warning annotation, since that action still targets Node 20. v5.2.8 runs on Node 24 natively. No call site here passes anywith:input to mise-action, so this is a pure pin bump.The smoke test asserted 200 for
/index.html, but the public handler serves the embedded SPA throughhttp.FileServerFS, which unconditionally redirects any request ending in/index.htmlto/with a 301 (verified against Go's net/http source and a standalone reproduction). That is correct, standard behaviour, not a defect in the handler, so the script's expectation was the side that needed fixing.Verification
task checkpasses locally exceptvalidate:kubeconform, which needs network this sandbox denies (TLS verification fails reaching the external schema host).shellcheck,shfmtandactionlintpass clean on the touched files.Risk
Low: a CI tooling pin and a test assertion, no application behaviour changes.
Open in [code]smith · Need help on this PR? Tag
@codesmithwith what you need.