Skip to content

fix: never block on a keyring that cannot answer - #133

Merged
overwrite00 merged 1 commit into
developfrom
fix/keyring-probe-and-tests
Nov 10, 2026
Merged

overwrite00 merged 1 commit into
developfrom
fix/keyring-probe-and-tests

Conversation

@overwrite00

Copy link
Copy Markdown
Owner

Summary

On macOS a locked Keychain can wait forever for a graphical confirmation, which hung the first use of the encrypted local key (seen as a stuck macOS job in the beta build).

  • The system keyring is probed with a 3 s limit before it is used; if it does not answer, the key file is used instead. Later keyring calls also have a time limit.
  • NULLIFYPDF_DISABLE_KEYRING=1 disables the keyring; the test suite sets it so tests never reach a real Keychain.
  • Tests with a keyring that never answers and with the environment switch.

Testing

  • pytest tests/: 338 passed locally
  • Full workflow on Windows, macOS and Linux (including package builds and installation tests): all green

@overwrite00 overwrite00 added type:bug Something isn't working lang:python Python-related scope:core Core library/framework changes labels Nov 10, 2026
@overwrite00 overwrite00 self-assigned this Nov 10, 2026
@overwrite00
overwrite00 merged commit f513e48 into develop Nov 10, 2026
15 checks passed
@overwrite00
overwrite00 deleted the fix/keyring-probe-and-tests branch November 10, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang:python Python-related scope:core Core library/framework changes type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant