[dpd,dpd-api,dpd-types] make external multicast constraints self-enforcing

.github/buildomat/jobs/test-proptest.sh

@@ -0,0 +1,36 @@
+#!/bin/bash
+#:
+#: name = "test-proptest"
+#: variety = "basic"
+#: target = "helios-3.0"
+#: rust_toolchain = true
+#: output_rules = [
+#:   "/work/proptest-regressions/**/*",
+#: ]
+#:
+
+set -o errexit
+set -o pipefail
+set -o xtrace
+
+source .github/buildomat/common.sh
+
+NEXTEST_VERSION='0.9.97'
+nextest_tmp="$(mktemp -d)"
+trap 'rm -rf "${nextest_tmp}"' EXIT
+nextest_tar="${nextest_tmp}/nextest.tar.gz"
+curl -sSfL --retry 10 -o "${nextest_tar}" \
+	"https://get.nexte.st/${NEXTEST_VERSION}/illumos"
+mkdir -p "${CARGO_HOME:-${HOME}/.cargo}/bin"
+tar -xzf "${nextest_tar}" -C "${CARGO_HOME:-${HOME}/.cargo}/bin"
+
+status=0
+pushd dpd-types/versions
+PROPTEST_CASES=1000000 cargo nextest run --lib proptests || status=$?
+if [[ -d proptest-regressions ]]; then
+	mkdir -p /work/proptest-regressions/dpd-types-versions
+	cp -r proptest-regressions/. /work/proptest-regressions/dpd-types-versions/
+fi
+popd
+
+exit "${status}"

Cargo.toml

@@ -84,6 +84,7 @@ kstat-rs = "0.2.4"
 lazy_static = "1.5"
 libc = "0.2"
 mockall = "0.14.0"
+nonempty = "0.12.0"
 omicron-zone-package = "0.12"
 openssl = "0.10"
 oxide-tokio-rt = "0.1.2"
@@ -92,6 +93,7 @@ predicates = "3.1.4"
 pretty_assertions = "1.4"
 progenitor = "0.15.1"
 progenitor-extras = "0.3.0"
+proptest = "1.10"
 rand = "0.9"
 regex = "1.12"
 regress = "0.11"
@@ -112,6 +114,7 @@ slog-term = "2.9"
 socket2 = { version = "0.6", features = ["all"] }
 strum = { version = "0.28", features = [ "derive" ] }
 tabwriter = { version = "1", features = ["ansi_formatting"] }
+test-strategy = "0.4"
 thiserror = "2.0"
 tokio = "1.37"
 toml = "1.0"

aal/src/lib.rs

@@ -109,11 +109,11 @@ pub enum AsicError {
     Synthetic(String),
     /// A general indication that a caller is trying to create something that
     /// already exists.
-    #[error("Already exists")]
-    Exists,
+    #[error("Already exists: {}", .0)]
+    Exists(String),
     /// A general indication that a caller is trying to modify something that
     /// is not present.
-    #[error("Missing")]
+    #[error("Missing: {}", .0)]
     Missing(String),
 }
 
@@ -126,6 +126,10 @@ pub trait AsicMulticastOps {
     /// For a given multicast group, return the number of ports assigned to it.
     fn mc_port_count(&self, group_id: u16) -> AsicResult<usize>;
 
+    /// For a given multicast group, return the ASIC identifiers of the ports
+    /// assigned to it.
+    fn mc_port_list(&self, group_id: u16) -> AsicResult<Vec<AsicId>>;
+
     /// Add a port to a multicast group. The port is identified using its ASIC
     /// identifier.
     fn mc_port_add(