Repository navigation
[mcast, vlan] match mcast NAT ingress on dst only (and not w/ the VLAN) - #408
Open
zeeshanlakhani wants to merge 6 commits into
Open
zeeshanlakhani wants to merge 6 commits into
zeeshanlakhani wants to merge 6 commits into
Conversation
In oxidecomputer/sidecar-lite#152 (oxidecomputer/sidecar-lite#152 (comment)), Ry reminded me that we're just a router here, that there's no VLAN isolation in the rack, and, like unicast, VLANs are not expected to be preserved across a routed boundary. Group IPs are unique in dpd, making it enough to match on the destination address for the multicast group. This work unspools the ingress table key-matching we had previously, where now multicast NAT ingress matches on `dst_addr` only. Note: we now validate the configured egress VLAN ID up front on create/update operations, before table writes occur.
zeeshanlakhani
requested review from
FelixMcFelix,
cfzimmerman and
rcgoodfellow
October 20, 2026 05:20
FelixMcFelix
approved these changes
Oct 28, 2026
FelixMcFelix
left a comment
FelixMcFelix
left a comment
Contributor
There was a problem hiding this comment.
Considerably simpler; if this is the consensus on what to do, then I'm all for it. Just one question on mechanics.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In oxidecomputer/sidecar-lite#152 (oxidecomputer/sidecar-lite#152 (comment)), Ry reminded me that we're just a router here, that there's no VLAN isolation in the rack, and, like unicast, VLANs are not expected to be preserved across a routed boundary. Group IPs are unique in dpd, making it enough to match on the destination address for the multicast group.
This work unspools the ingress table key-matching we had previously, where now multicast NAT ingress matches on
dst_addronly.Note: we now validate the configured egress VLAN ID up front on create/update operations, before table writes occur.