Repository navigation
[mcast, p4] drop mcast pkts coming from the userspace service port - #415
Open
zeeshanlakhani wants to merge 1 commit into
Open
zeeshanlakhani wants to merge 1 commit into
zeeshanlakhani wants to merge 1 commit into
Conversation
Any multicast packets that the switch zone hands back through the service port (with a sidecar header) shouldn't enter into replication. This update drops such packets as the first arm of `MulticastIngress` (with a port + sidecar check) and introduces an associated counter for this event. Link-local multicast v6 packets won't hit this condition, while IPv4 `224.0.0.0/24` dst packets also get dropped, same as oxidecomputer/sidecar-lite#181. We remain at 19 stages with this flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any multicast packets that the switch zone hands back through the service port (with a sidecar header) shouldn't enter into replication.
This update drops such packets as the first arm of
MulticastIngress(with a port + sidecar check) and introduces an associated counter for this event.Link-local multicast v6 packets won't hit this condition, while IPv4
224.0.0.0/24dst packets also get dropped, same as oxidecomputer/sidecar-lite#181.We remain at 19 stages with this flow.