Repository navigation
Support sorted region lists in humility dump - #755
Merged
Merged
Conversation
jamesmunns
reviewed
Nov 10, 2026
mkeeter
force-pushed
the
mkeeter/sorted-region-lists
branch
from
November 10, 2026 18:35
46ab827 to
864caea
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the archive-version and region-list compatibility update.
No open issues 🎉
What changed in this PR
Updates humility dump to handle Hubris’s new sorted region lists and accept archive version 14, while preserving support for existing region arrays.
Changes:
- Raises the maximum supported Hubris archive version from 13 to 14.
- Adds support for region lists wrapped in a single-member struct containing an array of 4-byte references.
| File | Description |
|---|---|
humility-core/src/hubris.rs |
Extends region-list parsing for the new wrapper format and bumps archive compatibility. |
Review effort: Balanced
jamesmunns
approved these changes
Nov 10, 2026
jamesmunns
left a comment
jamesmunns
left a comment
Contributor
There was a problem hiding this comment.
Two nits (let-else and comments), otherwise LGTM.
mkeeter
force-pushed
the
mkeeter/sorted-region-lists
branch
2 times, most recently
from
November 10, 2026 18:48
e120e27 to
cfdca61
Compare
labbott
approved these changes
Nov 10, 2026
mkeeter
force-pushed
the
mkeeter/sorted-region-lists
branch
from
November 10, 2026 19:07
cfdca61 to
d5781ee
Compare
mkeeter
enabled auto-merge (squash)
November 10, 2026 19:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly handle the new sorted region lists introduced by oxidecomputer/hubris#2760
(along with an archive version bump corresponding to oxidecomputer/hubris#2776)
I tested this on Grapefruit from
master, and saw the expected behavior (error without this fix, dump was fine with it)