Repository navigation
Conversation
On illumos nodes, `svcs -L` is used to find the log file for diagnostic collection. However, if the service doesn't exist the error message returned has an uneven number of quotes in it. e.g. ``` Pattern 'dendrite' doesn't match any instances ``` If this string is passed to another command on the tty, it leaves the shell hanging while it waits for the ending quote. This ensures we discard stderr and only accept stdout if the leading character is '/', since `svcs -L` returns an absolute filepath. Signed-off-by: Trey Aspelund <trey@oxidecomputer.com>
taspelund
requested review from
andrewjstone,
cfzimmerman,
internet-diglett,
nicolaskagami,
rcgoodfellow and
zeeshanlakhani
November 9, 2026 20:08
rcgoodfellow
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On illumos nodes,
svcs -Lis used to find the log file for diagnostic collection. However, if the service doesn't exist the error message returned has an uneven number of quotes in it.e.g.
If this string is passed to another command on the tty, it leaves the shell hanging while it waits for the ending quote.
This ensures we discard stderr and only accept stdout if the leading character is '/', since
svcs -Lreturns an absolute filepath.