Skip to content

vsock test flake in credit_update_sent_after_flushing_half_buffer #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
papertigers wants to merge 1 commit into from
Open

vsock test flake in credit_update_sent_after_flushing_half_buffer #1242

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/propolis/src/vsock/poller.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1516,7 +1516,9 @@ mod test {
accepted.read_exact(&mut buf).unwrap();
assert!(buf.iter().all(|&b| b == 0xAB));

// Look for a CREDIT_UPDATE in the RX used entries
// Look for a CREDIT_UPDATE in the RX used entries.
// NB: It arrives asynchronously so we attempt to wait on the condition.
wait_for_condition(|| harness.rx_used_idx() >= 2, 5000);
let rx_used = harness.rx_used_idx();
assert!(rx_used >= 2, "expected at least RESPONSE + CREDIT_UPDATE");

Expand Down
Loading