Repository navigation
VirtQueue should provide peek_avail - #1244
Open
papertigers wants to merge 3 commits into
Open
papertigers wants to merge 3 commits into
papertigers wants to merge 3 commits into
Conversation
papertigers
changed the base branch from
spr/papertigers/master.virtqueue-should-provide-peek_avail
to
spr/papertigers/vsock-ev-loop-should-start-paused
November 3, 2026 20:14
papertigers
force-pushed
the
spr/papertigers/virtqueue-should-provide-peek_avail
branch
from
November 5, 2026 21:31
9e93118 to
6a6ad18
Compare
papertigers
force-pushed
the
spr/papertigers/virtqueue-should-provide-peek_avail
branch
from
November 5, 2026 21:48
6a6ad18 to
39a063a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some consumers of VirtQueues such as vsock would like to be able to peek a descriptor chain rather
than always consuming it. This allows us to avoid a push_used of an empty write, while avoiding
the need to cache a chain which is tricky to get right and can lead to guest memory corruption. For
example if the cached chain is used after a device is reset and the guest placed the virtio rings in
a different location.