Repository navigation
Conversation
dancrossnyc
approved these changes
Nov 5, 2026
acfoltzer
approved these changes
Nov 5, 2026
acfoltzer
left a comment
acfoltzer
left a comment
Contributor
There was a problem hiding this comment.
Aha, it's good to know these kinds of memory considerations are important in these scripts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running this script on a busy host yesterday and it kept dropping
data because the dynamic variable space was exhausted. The problem is
that
fbt::svm_vmexit:entryis copying the whole ofvmcb->ctrlandvmcb->stateinto thread locals on every VM exit - that's about 4 KiB.Now that
vmcbis a pointer, we can just avoid doing those copies.