Repository navigation
[propolis-server-api] add an openapi-lint-clean API version - #1253
Merged
sunshowers merged 1 commit intoNov 9, 2026
Conversation
sunshowers
changed the base branch from
master
to
jj-stack/bump-bhyve-api-version-to-match-stlouis-llmrospv
November 9, 2026 01:04
sunshowers
force-pushed
the
jj-stack/propolis-server-api-add-an-openapi-lint-clean-api-version-myvqppon
branch
from
November 9, 2026 01:04
795b607 to
f27c9ca
Compare
Contributor
Author
Revision history
Generated by jj-stack from this pull request's force-push history. |
Prepare to lint OpenAPI documents with openapi-lint. Introduce the following changes in v7: - Enum string values become snake_case: `InstanceState`, `InstanceStateRequested`, `MigrationState`, and the tags of `InstanceInitializationMethod`, `InstanceSpecStatus`, and `ReplacementComponent`. - `InstanceVCRReplace` is renamed to `InstanceVcrReplace`. - `instance_issue_crucible_snapshot_request` and `instance_issue_nmi` return 204 No Content instead of 200 with a null body.
sunshowers
changed the base branch from
jj-stack/bump-bhyve-api-version-to-match-stlouis-llmrospv
to
master
November 9, 2026 01:07
sunshowers
force-pushed
the
jj-stack/propolis-server-api-add-an-openapi-lint-clean-api-version-myvqppon
branch
from
November 9, 2026 01:07
f27c9ca to
9d3653b
Compare
sunshowers
commented
Nov 9, 2026
Comment on lines
+91
to
92
| use propolis_api_types::instance::ReplacementComponent; | ||
| use propolis_api_types_versions::{v1, v2, v3, v6}; |
Contributor
Author
There was a problem hiding this comment.
This is the correct way to refer to these types per RFD 619.
ahl
approved these changes
Nov 9, 2026
Comment on lines
-91
to
-103
| "200": { | ||
| "description": "successful operation", | ||
| "content": { | ||
| "application/json": { | ||
| "schema": { | ||
| "title": "Null", | ||
| "type": "string", | ||
| "enum": [ | ||
| null | ||
| ] | ||
| } | ||
| } | ||
| } |
sunshowers
deleted the
jj-stack/propolis-server-api-add-an-openapi-lint-clean-api-version-myvqppon
branch
November 9, 2026 19:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare to lint OpenAPI documents with openapi-lint.
Introduce the following changes in v7:
InstanceState,InstanceStateRequested,MigrationState, and the tags ofInstanceInitializationMethod,InstanceSpecStatus, andReplacementComponent.InstanceVCRReplaceis renamed toInstanceVcrReplace.instance_issue_crucible_snapshot_requestandinstance_issue_nmireturn 204 No Content instead of 200 with a null body.