More miscellaneous cleanups

api/src/lib.rs

@@ -75,14 +75,15 @@ pub trait SushApi {
         headers: Header<Authorization>,
     ) -> Result<HttpResponseOk<Session>, HttpError>;
 
-    /// Check that this server would accept a job in a session.
+    /// Check that this server would accept a job in a session for a target.
     ///
-    /// Succeeds if the session is active or its start is pending.
-    #[endpoint { method = GET, path = "/sessions/{session_id}/check" }]
-    async fn session_check(
+    /// Succeeds if the session is active or its start is pending, and
+    /// the target resolves to at least one sled this server can reach.
+    #[endpoint { method = GET, path = "/sessions/{session_id}/preflight/{target}" }]
+    async fn job_preflight(
         ctx: RequestContext<Self::Context>,
         headers: Header<Authorization>,
-        params: PathParams<SessionIdParam>,
+        params: PathParams<SessionTargetParams>,
     ) -> Result<HttpResponseUpdatedNoContent, HttpError>;
 
     /// Get a fresh server nonce for the session ceremony.
@@ -258,6 +259,12 @@ pub struct SessionIdParam {
     pub session_id: SessionId,
 }
 
+#[derive(Deserialize, JsonSchema)]
+pub struct SessionTargetParams {
+    pub session_id: SessionId,
+    pub target: String,
+}
+
 #[derive(Deserialize, JsonSchema)]
 pub struct SessionAndJobIds {
     pub session_id: SessionId,

client/src/cli.rs

@@ -1132,7 +1132,7 @@ impl CommandContext for Cli {
                     .collect::<Result<Vec<_>, CommandError>>()?;
                 qprintln!("{}", json!({"identities": identities}));
             }
-            OutputFormat::Text if keys.is_empty() => self.note("❌ No SSH identities found"),
+            OutputFormat::Text if keys.is_empty() => self.note("❗ No SSH identities found"),
             OutputFormat::Text => {
                 for key in keys {
                     let key_id = key.key_id()?;
@@ -1151,16 +1151,6 @@ impl CommandContext for Cli {
         Ok(())
     }
 
-    fn really_target(&mut self, sled: &SledId) -> Result<(), CommandError> {
-        if read_bool(&format!(
-            "❓ Sled `{sled}` is not in the rack inventory. Proceed (yes/no)? "
-        ))? {
-            Ok(())
-        } else {
-            Err(CommandError::Canceled)
-        }
-    }
-
     fn please_touch(&mut self, identity: &SshPublicKey) -> Result<(), CommandError> {
         if identity.is_sk_algorithm() {
             eprintln!(