Repository navigation
work: retain native admission before queue publication - #1223
Draft
oxa-agent[bot] wants to merge 152 commits into
Draft
oxa-agent[bot] wants to merge 152 commits into
oxa-agent[bot] wants to merge 152 commits into
Conversation
# Conflicts: # oxa/oxa-work/src/lib.rs
# Conflicts: # oxa/oxa-work/src/lib.rs
…ted checkpoints (#333)
# Conflicts: # oxa/oxa-cli/src/work_cmd.rs # oxa/oxa-cli/tests/common/work.rs
…ng it `oxa --offline work ..` has to reach the work runner, and the previous change met that by replacing the whole leading subcommand block with an in-loop check. That deleted existing parser source for no behavioural gain and left the dispatch condition harder to read. Restore the block and add the one case the runner needs after it, scoped to `work`, so a command word after any other option stays an ordinary prompt word. This change removes nothing: the only other edit to existing source is the wider visibility of `report_cmd::tty_confirm`, which the work report workflow calls. No `Removes:` statement is needed. Tests: c12_argument_parsing pins that command words stay prompts after prompt words and options and that only a leading `--offline` dispatches `work`. fmt, clippy and the crate tests run in CI (#333).
…17-refill-consumer
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft: current head
ab46908b8f1a4dd2ddecdea38aaa4432bea958d3composes Core #1254 candidate99804ce10beca6701efc2487392f926327c6c1eband fixes pre-publication PR revision retention. Lane 44211239393 and draft checks 44211248989 are running for this exact head. Core qualification and normal final reviews remain pending; no merge or activation qualification is claimed.Feature A (#1214/#1017), T3; #307 night-watch + feeder + goal-loop row: assignment/leases and task packet/publication. Existing branch, protected Claims row, publisher and native runner. #1162, #1200, #1192, Core #1220 and native caller #407 are merged.
Consumer::oncerequires retention of the original Receipt(number,key,lease) after atomic idle admission and before the ready hardlink. The frontend binds the exact validated Prepared branch through Core NativeBinding. It now sets the public optional reviewed_head from the same revalidated Prepared PR revision, calls Core’s complete validate(), then invokes the existing full-lease bind_native CAS. Issues retain None. A validation/write error or false CAS prevents publication and preserves the charged reservation for reconciliation. No new constructor or Claims writer is introduced.The same real-binary publication fixture covers issue and PR packets. Its reopened binding assertion now names the actual published field and also requires None for issues; native identity, original lease, token, mismatch, dedupe and all protected-path controls remain. The real issue native-CLI fixture verifies canonical attempt identity, frozen packet bytes and first model request, actual acceptance command, durable nonzero whole-task checkpoint, original lease release, and repeat dispatch with no extra model request or claim. Retention error controls keep the charged reservation without publishing or retrying.
Removes: the admission-to-publication receipt gap and loss of the revalidated PR source revision. All guards and existing controls remain. Scoped Rust 2021 formatting and diff checks pass. No local builds or tests ran. Own source remains five files, 399 changed lines (365 additions, 34 deletions); dependent source is retained normally.
CI evidence:
46983bc9, lane 44188964299: actual CLI failed “CLI must retain native receipt.” The retention fix passed on both architectures at59804603.a9e57b7f, lane 44197798649: actual native command failed at its missing production route after refill/binding passed. Composed issue lifecycle0fcad849passed both architecture lanes 44206298372 and draft checks 44206308474, including frozen input, real acceptance, durable completion/release and no duplicate launch.fe6385f1, lane 44207924025: terminal FAILURE at work_refill_cli.rs:221, “PR admission must durably retain the exact reviewed revision.” ARM64 ran 1,520 tests, with 1,519 passing and only this control failing. Real PR revalidation, publication and binding reopen completed first. Draft 44207935685 passed. This was a runtime failure, not a compiler/fixture error.ab46908b: lane 44211239393 and draft checks 44211248989 pending. Earlier greens are historical receipts, not current qualification. Each current run has one 120-second App observer; no restart/dispatch or unchanged-head rerun.The Core API is actually present at 99804ce: existing new(...) remains compatible, reviewed_head is serde-default/omitted None, new_reviewed(...) and validate() validate the complete receipt. Work1 remains sole Core writer and #1254 is still draft/qualifying. This frontend uses its published public field and complete validation API before the existing binding write; it does not change Core or native execution code.
Lead owns complete-binding validation at packet take/materialization and carrying the reviewed PR number/head separately from the canonical native attempt ID into the frozen Task/checkpoint/checkout. Lead reports its focused source/negative controls are local; no execution ref is claimed published or qualified here. Combined real native CLI PR execution, missing/mismatched review metadata and advanced-branch refusal remain same-row gates before activation. The issue fixture and pre-hardlink PR retention can qualify independently, but do not attest that PR execution path. Runtime import/partition/shadow comparison and normal code/security/owner/queue gates remain. Helpers and publication/activation stay off.