Skip to content

Feature C: derive a bounded lead digest from runner facts (#307) - #1229

Merged
oxa-orchestrator[bot] merged 3 commits into
mainfrom
agent/1199-native-goal-observation
Nov 17, 2026
Merged

oxa-orchestrator[bot] merged 3 commits into
mainfrom
agent/1199-native-goal-observation

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Feature C (#1214, #1199). T2. Ports the deterministic since-last-look part of the digest + attn-watch row in #307.

The existing Facts journal supplies one coherent bounded snapshot and event window. The output reports merged PR evidence, newly blocked and cleared subjects, observed stall events, and the current count of waiting asks. A quiet window stays quiet. A retention gap or page limit returns the current snapshot as snapshot-only data and names the reason. Current verified worker liveness comes from the separate native reconciliation path.

Removes: the separate event-only read path. The existing events API and new digest share the bounded window read. The new digest is a read primitive for the existing Lead owner. Runtime activation remains default off.

The #1202 saved-session observation prerequisite is already merged at 3688e90f. This draft carries only the new digest paths at 3f0b795ac413e918647a7af490c4666f2936dd21. Targeted rustfmt and whitespace checks passed. The hosted lane will qualify durable reopen, quiet mechanical activity and both incomplete-window conditions.

The exact hosted lane and draft required gate passed at 3f0b795a. The PR is ready for review, with full ready checks started.

The full ready workflow passed on the same head. Codex code and security reviews reported no findings. Required checks · Code review · Security review

@oxa-agent

oxa-agent Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor Author

A/C #307 acceptance readback at 3f0b795a. The shared read_window gives this primitive a coherent fact snapshot and cursor under one lock. Two controls for its handoff to the owner conversation:

  • Put a real PrMerged fact after a byte-short first page, or after 64 mechanical facts. The current code returns SnapshotOnly(PageLimit) even though the interval is retained. If this is the intended one-page budget, the caller should disclose omitted history before acknowledging the snapshot sequence. Exercise retry after a failed digest record and repeat visit after successful recording. A retention gap and a page budget refusal have different causes.
  • Snapshot replay and Fact::class both consume incidents embedded in StandingChanged. The new match handles direct Incident(WorkerStalled) but ignores this envelope's incident. A valid standing revision with a stalled-worker incident and no ask transition therefore updates snapshot.incidents while the digest returns Quiet. Exercise the direct and embedded shapes, and keep both as observed stalls until the existing native reconciliation establishes current worker state or recovery.

Existing digest acceptance · Projection of standing incidents

Merged fact destination. #1232 at 7af30c3e resolves /items/{number} only against the open Board. Its item view becomes unavailable after the PR leaves that snapshot, even when the digest retains a verified PrMerged fact. In the composed caller, exercise a landed PR absent from the open board and verify that its fact link reaches the corresponding merged evidence. Keep the destination tied to the existing canonical snapshot or the verified external PR source. Current item resolver

@oxa-agent
oxa-agent Bot marked this pull request as ready for review November 17, 2026 22:42
@n0rpan

n0rpan commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@n0rpan

n0rpan commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T22:47:23.884561Z 3f0b795 Manual request
🔒 Security Review ✅ Completed 2026-11-17T22:48:30.020875Z 3f0b795 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 3f0b795ac4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 3f0b795ac4

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit 010cd88 Nov 17, 2026
50 checks passed
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/1199-native-goal-observation branch November 17, 2026 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant