Repository navigation
feat(lead): bound board views to real 50-row pages (#1030) - #1238
oxa-agent[bot] wants to merge 9 commits into
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Feature D (#1214); refs #1030's approved v2 design. Ports #307 row digest + attn-watch (acceptance). T3 for finite query routing at the existing authorized boundary.
Board views render at most 50 rows. Show more and First page are normal server-rendered links over the same complete snapshot, with matching bounded fragments and Board selected. Page numbers must be canonical positive integers with checked offset multiplication. Counts describe the complete observation; pagination changes no intake, queue, attempt or acquisition limit.
Removes: unbounded row rendering. No additional source read, GitHub request, producer, cache, store or write handler. Own diff: 80 changed lines in four files. Private mock uncommitted; helpers paused; no new activation.
Before 1ab96f9 failed lane44198452867 on both architectures. Failed-job134446107218 tail confirmed 1,279/1,280 passing with the real-binary listener finding row51 on the first page. Its unchanged controls check non-overlapping50/50/1 rows from101 synthetic observations, document/fragment responses, hostile Host denial and malformed/overflowing page refusal.
Current head 8678012 normally merges main1f80c439 after primary GitHub and merge-tree proved ae4d28f CONFLICTING. Main Chat/Prompt routes, compose styles and native APIs are retained with board pagination. Complete main Chat and own paging real-server blocks were verified byte-for-byte unchanged, Chat before board writes; the Chat module and every main CSS line are preserved.
Current lane44207066477 and required44207077575 qualify this head, one interval120 observer each. Historical ae4d28f passed lane44200354145 (oxa-cli/parity, both architectures) and full44202535184, including strict clippy/binary/doctests/archive/both mandatory-bwrap partitions/inventory/gate; earlier greens do not substitute for current8678 checks. No local builds/tests, Ready toggle, empty commit, manual dispatch, CI restart or enqueue request. Normal independent review and merge queue remain required.
Current component result: exact8678012262df04cb5dae4429dace9a8e7b734e51 passed lane44207066477 on x86_64 and ARM64, selecting oxa-cli/parity (plan134475626843). Real server Chat plus50/50/1 paging, strict query and Host refusal controls passed together. Observer81044 terminated successfully and is consumed. Required44207077575 remains under its original single observer; no restart or repeat lane.
Current full result: exact8678012262df04cb5dae4429dace9a8e7b734e51 passed required44207077575, including strict clippy, real binary, doctests/archive, both mandatory-bwrap partitions, exact inventory and gate. Both current observers terminated successfully and are consumed. Normal independent reviews/owner/queue remain; no claim of landing.
Primary current-head Codex code review receipt reports no major issues and no unresolved review threads. Independent owner/security and queue/integration gates still apply.