Skip to content

Feature A — Bind queue removals to owner-journal admissions (#307 merge-flow) - #1245

Open
oxa-agent[bot] wants to merge 2 commits into
mainfrom
agent/307-admission-journal
Open

oxa-agent[bot] wants to merge 2 commits into
mainfrom
agent/307-admission-journal

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Feature A · Native work board

Ports the admission evidence portion of #307 merge-flow → board landing under #1214 and #1017. T2. Based on main after #1215 and #1239.

Replay the existing owner journal to bind a verified queue removal to a prior observed admission of the same PR head and exact merge-group SHA. Record the original queue observation and the main SHA first observed with that rejection. Preserve both across repeated observations and restarts. A removal that precedes the admission or a different head or group does not match.

The existing opt-in landing shadow writes this evidence to its existing owner journal. It projects observations only. Delivery and retry receipts remain separate owner-confirmed evidence.

The integration test opens the real journal across samples, including repeated admission observations, a later main ref, an unrelated group, a stale removal after a later admission, and a replaced PR head. Formatting, whitespace checks, and isolated compilation of all oxa-work test targets passed locally. Exact-head required CI passed, including both mandatory-bwrap partitions. The journal integration test passed in shard 2 in 0.004 seconds. Independent code review remains pending.

Removes: nothing.

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T00:30:22.474089Z 4223b84 Manual request
🔒 Security Review ✅ Completed 2026-11-18T00:31:19.884727Z 4223b84 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: c22b84b74c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: c22b84b74c

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4223b84c09

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +71 to +73
let reader = BufReader::new(log.take(MAX_LOG_BYTES));
for prior in serde_json::Deserializer::from_reader(reader).into_iter::<PriorSample>() {
let prior = prior.map_err(|_| "cannot read owner shadow journal")?;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Validate JSONL boundaries when replaying the journal

serde_json::Deserializer::into_iter() reads a stream of JSON values, not newline-delimited records: it accepts both two adjacent objects on one line and a complete final object without a terminating newline. Consequently, admission_replay_refuses_multiple_objects_on_one_complete_line fails, as does the complete-object fragment case in admission_replay_rejects_and_open_log_preserves_interrupted_tail_bytes. Replay also accepts the malformed complete line that the former test intends to reject. Parse each newline-terminated record separately and reject an unterminated tail so replay enforces the journal's framing contract.

Useful? React with 👍 / 👎.

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 4223b84c09

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant