Repository navigation
Feature A/C — Fence native PR execution to the reviewed head (#1199) - #1267
Draft
oxa-agent[bot] wants to merge 5 commits into
Draft
oxa-agent[bot] wants to merge 5 commits into
oxa-agent[bot] wants to merge 5 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T2. Feature A/C, #1017 and #1199, #307 native queue and assignment execution.
The runner validates the retained binding at packet take and task materialization. It carries the PR number and reviewed SHA separately from the canonical attempt ID. Common admission checks direct JSON tasks too. Reviewed execution uses the existing exact-head checkout fence and freezes acceptance against the reviewed merge base.
The tests-first lane reproduced the valid PR binding refusal on both architectures at
d757fa39. At65e45e59, the queue correctly refused to settle the advanced-branch case, but its outer event omitted the checkout reason. The fixture at960b2178checks that reason in the durable task record.Hosted lane passed 1,551 tests on each architecture at
960b2178fd9f5c58702b54d02cdb05c914d2b502. Both logs pass the first reviewed PR checkout and settlement, missing/mismatched/advanced-head refusal before model use, and the original issue whole-job/replay control. Draft checks passed.Current tests-first follow-up
042f75bdpublishes the second reviewed round in the existing protected refill/native CLI fixture. It requires a distinct original lease and exact reviewed SHA for each round, release after both finishes, and byte-for-byte preservation of the first checkpoint. The first-round receipt above is historical. This draft remains gated on the typed lineage repair in the owner lane.Two-round before-fix lane at
042f75bdfailed only the second reviewed-round completion on each architecture, after passing the first and admitting the distinct new lease generation. Draft checks passed. Owner repair handoff.Main merge
fec336c0resolves the conflict from #1279 inqueue/native.rs. Both existing isolated lock-test guards remain. The seven-file reviewed-source patch has identical added and removed lines, and the two-attempt CLI fixture is byte-identical to the before head. Current hosted lane and draft checks started. The typed lineage dependency remains with #1265.