Repository navigation
Feature C — Resume a compacted Lead Session with canonical standing (#1199) - #1309
Conversation
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
@codex security review |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Feature C · #1199 part 2 · #307 row
codex-send/bridge· T1#1282 covers durable recovery after killing a real turn. #1296 verifies that loading a Session file with a compaction record retains the full goal checkpoint.
This test drives native Session compaction, reopens the same file through
Open::Resume, and takes another turn over the compacted transcript. It compares the saved goal, exact ask, standing references, and full held lease. The resumed references resolve to the full original decision and rule in the existing standing store. The mock request must contain the exact saved summary and omit the old standalone message. The only change is one CLI test file disjoint from Work1, Work2, and the managed Inbox work.The first selected lane stopped at the fixture's assumed mock summary. The second lane reached and passed the state assertions on ARM64, then could not match the raw resumed prompt with environment notes enabled. The current fixture checks the exact saved summary, disables environment notes, and selects the chat issued after reopening.
7a92ba16ran the new test and passed 1,394/1,394 with no skips on each architecture. x86_64 receipt · ARM64 receipt