Skip to content

Feature C — Resume a compacted Lead Session with canonical standing (#1199) - #1309

Merged
oxa-orchestrator[bot] merged 3 commits into
mainfrom
agent/1199-lead-compaction-resume
Nov 18, 2026
Merged

oxa-orchestrator[bot] merged 3 commits into
mainfrom
agent/1199-lead-compaction-resume

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Feature C · #1199 part 2 · #307 row codex-send/bridge · T1

#1282 covers durable recovery after killing a real turn. #1296 verifies that loading a Session file with a compaction record retains the full goal checkpoint.

This test drives native Session compaction, reopens the same file through Open::Resume, and takes another turn over the compacted transcript. It compares the saved goal, exact ask, standing references, and full held lease. The resumed references resolve to the full original decision and rule in the existing standing store. The mock request must contain the exact saved summary and omit the old standalone message. The only change is one CLI test file disjoint from Work1, Work2, and the managed Inbox work.

The first selected lane stopped at the fixture's assumed mock summary. The second lane reached and passed the state assertions on ARM64, then could not match the raw resumed prompt with environment notes enabled. The current fixture checks the exact saved summary, disables environment notes, and selects the chat issued after reopening.

@oxa-agent
oxa-agent Bot marked this pull request as ready for review November 18, 2026 05:23
@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T05:43:25.422620Z 7a92ba1 Manual request
🔒 Security Review ✅ Completed 2026-11-18T05:44:38.555657Z 7a92ba1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 7f56b9c3ef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 7a92ba16b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 7a92ba16b8

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 3d578eb Nov 18, 2026
32 checks passed
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/1199-lead-compaction-resume branch November 18, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant