Skip to content

Feature A: Hold native landing for unresolved exact-head review findings (#1411) - #1425

Merged
oxa-orchestrator[bot] merged 3 commits into
mainfrom
agent/1411-native-landing-hold
Nov 18, 2026
Merged

oxa-orchestrator[bot] merged 3 commits into
mainfrom
agent/1411-native-landing-hold

Conversation

@oxa-agent

@oxa-agent oxa-agent Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Feature A · T3 · #1411 · #307 merge-flow row (comment 6958648117).

The native landing Reader now requires completed Code review on the exact PR head for clearance. Missing, pending, or stale clean review produces wait_review. Unresolved findings retain the hold even when Security is clean and the Board has recorded approval.

When a completed review on the exact head has unresolved findings, the shadow decision can show a proposal to disable active auto-merge or dequeue an observed member. Both proposals carry the PR node ID and exact head. There is no executor or live queue mutation in this change.

The existing Reader fixture covers a finding that appears after queue admission, a separate clean Security receipt, missing/pending/stale Code, exact-current clearance, and the interventions independently. Offline targeted type checks, rustfmt and diff checks passed. Strict local Clippy on the earlier preserved head stopped on warnings in unchanged worker files. At exact 97ac5b14, both hosted architectures ran the named landing regression and passed all 1,647 selected tests with zero skips. Draft checks and CodeQL also passed. Selected CI · Draft checks · CodeQL

The full rerun stack with #1349 was also qualified on the isolated exact tree 9190a002. Both x86_64 and ARM64 passed 1,655 tests with zero skips, including this exact-head hold, retry reconciliation, and the restart guard against duplicate dispatch. This is compatibility evidence for the combined source. Protected live acceptance remains tracked in #1378. Hosted CI · Archive

@oxa-agent
oxa-agent Bot marked this pull request as ready for review November 18, 2026 12:08
@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex review

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T12:12:59.640912Z 97ac5b1 Manual request
🔒 Security Review ✅ Completed 2026-11-18T12:17:54.019213Z 97ac5b1 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 97ac5b1416

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@n0rpan

n0rpan commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 97ac5b1416

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 97ac5b1416

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@oxa-orchestrator
oxa-orchestrator Bot added this pull request to the merge queue Nov 18, 2026
Merged via the queue into main with commit 7714b98 Nov 18, 2026
53 checks passed
@oxa-orchestrator
oxa-orchestrator Bot deleted the agent/1411-native-landing-hold branch November 18, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant