Repository navigation
Feature A: Hold native landing for unresolved exact-head review findings (#1411) - #1425
Conversation
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex security review |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Feature A · T3 · #1411 · #307 merge-flow row (comment 6958648117).
The native landing Reader now requires completed Code review on the exact PR head for clearance. Missing, pending, or stale clean review produces
wait_review. Unresolved findings retain the hold even when Security is clean and the Board has recorded approval.When a completed review on the exact head has unresolved findings, the shadow decision can show a proposal to disable active auto-merge or dequeue an observed member. Both proposals carry the PR node ID and exact head. There is no executor or live queue mutation in this change.
The existing Reader fixture covers a finding that appears after queue admission, a separate clean Security receipt, missing/pending/stale Code, exact-current clearance, and the interventions independently. Offline targeted type checks, rustfmt and diff checks passed. Strict local Clippy on the earlier preserved head stopped on warnings in unchanged worker files. At exact
97ac5b14, both hosted architectures ran the named landing regression and passed all 1,647 selected tests with zero skips. Draft checks and CodeQL also passed. Selected CI · Draft checks · CodeQLThe full rerun stack with #1349 was also qualified on the isolated exact tree
9190a002. Both x86_64 and ARM64 passed 1,655 tests with zero skips, including this exact-head hold, retry reconciliation, and the restart guard against duplicate dispatch. This is compatibility evidence for the combined source. Protected live acceptance remains tracked in #1378. Hosted CI · Archive