Repository navigation
oxa: wait with a deadline and wake on real attention instead of polling #902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
n0rpan
wants to merge
13
commits into
main
Choose a base branch
from
oxa/issue-877
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+830
−42
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
145eb7e
oxa: wait with a deadline and wake on real attention instead of polling
n0rpan 88285d2
oxa: run the boot preload when a session is ready, not on the idle tick
n0rpan fd662ea
oxa: end the turn's activity when the run is dropped or aborted (#699)
n0rpan 2f814a3
Merge main into oxa/issue-877
n0rpan b7cf424
oxa: wait for the foreground turn in the interrupt pty check
n0rpan efd0957
oxa: start a new run for input typed while an abort unwinds (#906)
n0rpan 1dadeac
Merge main to resolve current attention wake conflicts
b08c8ff
test(interactive): require worker exit when front end disconnects
0c9d146
fix(interactive): keep worker attention sender weakly owned
62cf43c
fix(interactive): align worker entry point with weak wake ownership
fec4cf8
test(interactive): cover unconsumed start and settled Escape windows
4177d9a
fix(interactive): preserve active and canceled input boundaries
614a0cc
Merge main while retaining Escape recovery controls
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a stream breaks after producing output and automatic replay is enabled,
run_innerpersistsShown { why: CUT }and continues the same run with another request. This clearsgate.running, but neither the replay branch nor subsequent turns restore it; only a newrun_loopinvocation does. If the UI consumes the cut entry and entersterm.pollbefore consuming the replay'sMessageStart, both its activity and the shared signal report idle even while the replay executes. Enter consequently submits a separate prompt instead of steering, and Ctrl+C clears the editor instead of cancelling the request. Keep the foreground signal active for recoverable cuts, or restore it before continuing the request.Useful? React with 👍 / 👎.