Repository navigation
Cap the size of a response roxy will proxy - #81
Merged
Merged
Conversation
roxy is a public, unauthenticated proxy – nothing stops a request for an arbitrarily large file, spending both the target’s bandwidth and this server’s. Capped at 10 MB, well past any real feed. Applied in two places: the raw bytes read off the wire, and separately the decompressed size for a gzip response – a small compressed payload can still expand into a much larger one (a “zip bomb”), so capping only the wire size wouldn’t actually bound memory use for a gzip response. Verified directly: a real oversized payload is rejected, content exactly at the cap still passes, a 50 KB gzip payload that expands to 50 MB is caught by the decompression cap specifically (not just the wire-size one), and normal small responses – gzip and otherwise – still decompress correctly. Existing test.sh suite still passes unchanged. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roxyis a public, unauthenticated proxy – nothing stops a request for an arbitrarily large file, spending both the target's bandwidth and this server's. Capped at 10 MB, well past any real feed.Test plan
Response too large to proxy)test.shsuite still passes unchanged🤖 Generated with Claude Code