fix(docs): add a note about bundling and merge_pr_in_ci - #1165
Conversation
|
🤖 Finished Review · ✅ Success · Started 8:15 AM UTC · Completed 8:28 AM UTC Commit: |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 14s |
ReviewFindingsLow
Labels: PR adds documentation about the merge_pr_in_ci configuration key |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
| RPM packages with an NVR referencing an unknown hash (the one created by the | ||
| Packit merge commit). | ||
|
|
||
| :::tip Packages with bundled dependencies |
There was a problem hiding this comment.
[low] scope-vs-intent
The linked issue (packit/packit#2733) reports a code bug in packit's prepare-sources path where git checkout main fails on vendored files. This PR closes the issue by documenting a workaround (merge_pr_in_ci: false) rather than fixing the code. Per maintainer analysis in the issue comments, the code fix approach was deliberately declined. Consider keeping the issue open or noting the resolution rationale before closing.
Suggested fix: Either keep the issue open and remove the Fixes closer from the PR body, or note the resolution rationale in the issue comments before closing.
fullsend-ai-review
Bot
added
ready-for-merge
betulependule
left a comment
betulependule
left a comment
There was a problem hiding this comment.
The content is fine and looks ok when viewed in a browser. LGTM
Fixes packit/packit#2733 Fixes PACKIT-5184 Signed-off-by: Matej Focko <mfocko@packit.dev>
b168edc to
27f51ab
Compare
|
🤖 Finished Review · ✅ Success · Started 1:47 PM UTC · Completed 1:57 PM UTC Commit: |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 09s |
|
Review skipped — this PR is already merged. The Posted by fullsend post-review check |
3 participants
Fixes packit/packit#2733
Fixes PACKIT-5184
Since there is no reply on the issue, I’m adding a note to the docs and closing down the issue.