Skip to content

test: batch fold 5577, 5580, 5582 (apr-cli, contracts, compute coverage) - #5583

Open
noahgift wants to merge 14 commits into
mainfrom
batch/test-fold-5577-5582
Open

noahgift wants to merge 14 commits into
mainfrom
batch/test-fold-5577-5582

Conversation

@noahgift

@noahgift noahgift commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Batch fold of three branch-only test tickets (cherry-picked with -x), plus the derived-file regen (contracts.nt, README count 1985 via readme_sync.sh):

Not folded: B5 (stacks on #5559) and test/wsweep-5579 (clippy red on main code, owner fixing).

Refs #5577 #5580 #5582

🤖 Generated with Claude Code

keep-open: test-coverage tickets stay open until their owners confirm
ont-delta: none test-only fold, no ontology delta

noahgift and others added 4 commits October 18, 2026 20:12
…gest, falsifier 006 (Refs #5577)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 8626c7c)
…v1 contract (Refs #5580)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit 7a55cca)
Adds C-BLIS-ELEMENTWISE-INPLACE with two falsifiers; relu max->min mutation
turns 2 tests RED.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
(cherry picked from commit a2e8060)
…e folded contracts

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @bb7d0f97a04ebb0252c1734db8418c3c29e8141e APPROVE

Own-trailer check: 0 of the PR's commits. Read every .rs hunk: only #[cfg(test)] additions in apr-corpus-ingest (civil_from_days epoch/leap/1900 boundaries, now_utc_iso8601 shape), blis elementwise (relu_inplace incl. tail lengths vs out-of-place relu, mul_scalar_alloc), and pv query_enrich_tests (build_diff_info on a tracked file, days_ago vs parse_iso_days_ago, untracked path -> None). No production code changed. The date constants check out (day 11016 = 2000-02-29). Contract/README/nt/findings changes are derived regen + 2 findings lines; skimmed, not regenerated by me. Not run locally.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-pace @bb7d0f97a04ebb0252c1734db8418c3c29e8141e

Non-author read of the full diff (0 aprender-pace trailers). Tests only: new #[test]s in apr-corpus-ingest, blis/elementwise and query_enrich_tests, all inside test modules; the .unwrap() calls are in test code like the existing tests there. README 1983→1985 matches the 2 new contracts (blis-elementwise-inplace-v1, pv-query-diff-info-v1), and contracts.nt has 5 triples for each. The added falsification entry names its test. Findings are jsonl, no issues. No defect found.

@noahgift
noahgift enabled auto-merge October 18, 2026 18:15
…baseline is shrink-only)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @7be03853773b2c0b3d1a613c4c2ecf7139799b43 APPROVE

Re-seat after the push. Own-trailer check: 0. Delta since my seat at bb7d0f9 read in full: 2 contract files, 3 formal: lines only (relu_inplace == relu; len(commit_hash)=40 and len(last_modified)=10; untracked path => None), each matching the tests I already read. No .rs change, so the earlier test-only review stands. Not run locally.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-pace @7be03853773b2c0b3d1a613c4c2ecf7139799b43

Re-seat. Delta since bb7d0f9 is 2 contract YAMLs, 3 formal: lines rewritten with declared symbols (∀, ≡, ∧, ∉, ⇒); no code change. Each line still states what its named test asserts (relu_inplace≡relu; 40-char hash / 10-char date; None for a path with no history). 0 aprender-pace trailers in the delta. My earlier read of the rest still stands. No defect found.

@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

§13.11 rung 1 — quorum shadow verdict

S13-SHADOW pr=5583 head=f6272fd6d577960c248dfc4c93a7b354e6d4a4c1 verdict=REFUSE class=Q1 arm_rc=1

Shadow mode: this records a verdict and merges nothing. A refusal
to arm is not a block (§13 adds zero rows to §7) — the pull request is
exactly as green as it was.

…changes

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @62628eaafc45cd697a788ee2a70fb9ea9c8182bd APPROVE

Re-seat. Own-trailer check: 0. Delta since my seat at 7be0385: one file, contracts/witness/811c7818...json, +2 -2 (regenerated witness hashes). No source change; my earlier test-only review stands. I did not re-derive the witness hashes. Not run locally.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-pace @62628eaafc45cd697a788ee2a70fb9ea9c8182bd

Re-seat. Delta since my last seat is one regenerated ONT witness JSON (census_id_set_sha256 + reasoner_git_sha); no code or contract change. 0 aprender-pace trailers in the delta. Earlier read stands. No defect found.

…ence file needs a surface_audit.csv re-audit (dogfood G2.1)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @2f2abe0666deb8bbfcdfb899dd86d5d1b57266e0 APPROVE

Re-seat on the new head. Read: contracts blis-elementwise-inplace-v1 and pv-query-diff-info-v1 with falsifiers, regenerated README/contracts.nt/census/witness, and the aprender-compute elementwise and aprender-contracts query_enrich tests; a3 says the #5577 test was reverted to clear dogfood G2.1 (I did not independently confirm the revert beyond the file list). Not run: tests, mutations, CI. Own trailers: 0.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-pace @2f2abe0666deb8bbfcdfb899dd86d5d1b57266e0

Re-seat. Delta since 62628ea is 32 deletions in 3 files and 0 additions: the #5577 corpus-ingest date tests, their contract entry in bin-apr-cli--aprender-corpus-ingest-v1.yaml and its finding line are removed together, so no entry is left pointing at a missing test. No contract file added or dropped, so the README count and witness are unaffected. 0 aprender-pace trailers in the delta. Earlier read of the rest stands. I did not run the tests. No defect found.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correction: my seat above on @2f2abe0666deb8bbfcdfb899dd86d5d1b57266e0 is seat 2 (pace holds seat 1), not seat 1. aprender-triage-worker APPROVE stands.

@noahgift
noahgift disabled auto-merge October 18, 2026 20:14
@noahgift
noahgift enabled auto-merge October 18, 2026 20:14
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-pace @9f6792d697320606cf0ac592712feb9f49ad50fb

Empty-delta re-seat since my @2f2abe0666deb8bbfcdfb899dd86d5d1b57266e0. The git tree at this head is byte-identical to that commit (same tree object), so only the commit changed (ci: refresh event payload). My earlier read stands. 0 aprender-pace trailers.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @9f6792d697320606cf0ac592712feb9f49ad50fb APPROVE

Re-seat: delta from my previous seat is one empty commit ("ci: refresh event payload for closing-refs guard"), 0 files changed. Own-trailer count 0. Not run: tests (no content change).

@noahgift
noahgift disabled auto-merge October 18, 2026 22:20
@noahgift
noahgift enabled auto-merge October 18, 2026 22:20
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @6580ab0f1bc6db0d5cd4ca08d222abcfef2c9255 APPROVE

Re-seat: delta from my previous seat is one empty commit (0 files changed). Own-trailer count 0. Not run: tests (no content change).

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @6580ab0f1bc6db0d5cd4ca08d222abcfef2c9255

Empty-delta re-seat: tree of this head is identical to the tree I seated at 9f6792d (checked with git rev-parse ^{tree}); only the commit message marker changed. No code re-read beyond that. 0 aprender-pace trailers.

@noahgift
noahgift disabled auto-merge October 19, 2026 00:23
@noahgift
noahgift enabled auto-merge October 19, 2026 00:23
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @1e3476ef704bcdc2af75d1dabdf611ccbc22f2e9 APPROVE

Re-seat of derived-only push. Read: compare 9f6792d...1e3476e (commit list + file count). Delta is main-merge commits (already-merged PRs) plus "merge origin/main - derived files regenerated"; no PR-authored source commit beyond what I seated before. Not run: tests/regen. Trailers: 0.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @1e3476ef704bcdc2af75d1dabdf611ccbc22f2e9

Re-seat of my earlier seat @6580ab0f1bc6. Compared the PR's own diff (merge-base with origin/main, excluding contracts.nt, witness and README) before and after: no differing +/- lines, so this push is a main merge plus regenerated files. I did not re-inspect the regenerated witness/contracts.nt/README content. 0 aprender-pace trailers. CI not read, tests not run.

@noahgift
noahgift added this pull request to the merge queue Oct 19, 2026
@noahgift
noahgift removed this pull request from the merge queue due to a manual request Oct 19, 2026

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @e92069371aadfe7902ff702cddb47ce84227343e APPROVE
Re-seat after main merge. Delta from my last seat (1e3476e): one line in contracts/contracts.nt (derived); the other 7 PR files are unchanged. Derived file not re-derived. 0 own-author trailers. Not run: build, tests, CI.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @e92069371aadfe7902ff702cddb47ce84227343e

Re-seat after a merge of main (a3: seats void). Empty delta: the PR's own diff against its merge-base (generated witness/contracts.nt/README excluded) is identical between my previous seat @1e3476ef704b and this head, so my earlier review stands unchanged. (Reviews on 6580ab0 also exist; compared against 1e3476e.) 0 aprender-pace trailers. CI not read.

@noahgift
noahgift enabled auto-merge October 19, 2026 07:19
noahgift and others added 3 commits October 19, 2026 12:43
# Conflicts:
#	README.md
#	contracts/witness/811c78184eb2609244c59534f015f0be2f90923120a3027c176ad56723d0d850.json
#	docs/findings/w5382.jsonl
…ailed ont5/lint gates)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant