Skip to content

test(registry): fold DownloadProgress human accessors coverage - #5672

Open
noahgift wants to merge 3 commits into
mainfrom
batch/test-fold-registry-progress
Open

noahgift wants to merge 3 commits into
mainfrom
batch/test-fold-registry-progress

Conversation

@noahgift

@noahgift noahgift commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Folds test/registry-download-progress-human (05fb358): DownloadProgress human accessors, new contract aprender-registry-download-progress-v1. Formal line rewritten with declared glyphs; nt, witness and README count regenerated. Refs w5382 finding.
keep-open: test-coverage tickets stay open until their owners confirm
ont-delta: none test-only fold, no ontology delta

🤖 Generated with Claude Code

noahgift and others added 2 commits October 18, 2026 23:28
New contract C-REGISTRY-DOWNLOAD-PROGRESS; mutation (downloaded_human reads total) turns 1 test RED.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Agent: aprender-w5382
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 2, aprender-pace @a8e6062caf375be1d9950799259aab2b25886886

Read: a coverage fold with no production change. It adds the progress_human_tests module in aprender-registry cache.rs: 3 tests for eta_human (42.9 s, 125 s, 3725 s), and for downloaded_human and total_human reading their own fields (1536 B, 5 MiB). The expected strings are consistent with format_bytes (KB/MB thresholds, 2 decimals); I did not trace format_duration. The new C-REGISTRY-DOWNLOAD-PROGRESS contract passes pv validate, with a mutation named and a formal line in Σ form. README goes 1983 to 1984 (+1), contracts.nt gets 5 triples, and the witness is regenerated. 0 aprender-pace trailers. I did not run the tests.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat N, aprender-triage-worker @a8e6062caf375be1d9950799259aab2b25886886 APPROVE

Read: test-only fold — aprender-registry cache.rs progress_human_tests (eta_human 42s/2m 5s/1h 2m, downloaded_human and total_human each read their own field), new aprender-registry-download-progress-v1 contract with a stated mutation, regenerated README/nt/census/witness. No production-code change. Not run: tests, mutation, CI. Own trailers: 0.

@noahgift
noahgift enabled auto-merge October 18, 2026 21:30
@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

§13.11 rung 1 — quorum shadow verdict

S13-SHADOW pr=5672 head=16afd47f9aaea2c3664c5a905a75781525227c04 verdict=REFUSE class=Q1 arm_rc=1

Shadow mode: this records a verdict and merges nothing. A refusal
to arm is not a block (§13 adds zero rows to §7) — the pull request is
exactly as green as it was.

@noahgift
noahgift added this pull request to the merge queue Oct 18, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 19, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-triage-worker @16afd47f9aaea2c3664c5a905a75781525227c04 APPROVE

Re-seat. Own-trailer count 0. Since my seat at a8e6062 the PR gained a588314 (test(registry): DownloadProgress eta_human/downloaded_human/total_human tests, new contract aprender-registry-download-progress-v1.yaml, +5 contracts.nt, README count +2/-2, witness regen, findings line) and a merge of origin/main (witness regenerated).
Read: the three new tests in crates/aprender-registry/src/cache.rs (+31, test-only module). Assertions are exact strings (42s / 2m 5s / 1h 2m / 1.50 KB / 5.00 MB), and the downloaded-vs-total tests use distinct values so swapped fields fail.
Not read / not run: the new YAML body, witness json, merge-from-main content, no test or pv run. This is one seat; a second reviewer is still needed.

@noahgift noahgift left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seat 1, aprender-pace @16afd47f9aaea2c3664c5a905a75781525227c04

Read the full diff (+89/-5, 6 files). Source change is a test module only in aprender-registry cache.rs. I checked the asserted strings against format_duration and format_bytes on main: 42.9s->"42s", 125s->"2m 5s", 3725s->"1h 2m", 1536 B->"1.50 KB", 5 MiB->"5.00 MB"; all match. README count, contracts.nt, witness and the w5382 findings line are generated/ledger files; I did not regenerate them. 0 aprender-pace trailers. Not verified: tests not run by me, CI not read.

@noahgift
noahgift enabled auto-merge October 19, 2026 03:25

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant