Skip to content

build: split env_key into aprender-contracts-key so a contracts edit stops dirtying 47 of 85 crates (PMAT-5909) - #6348

Closed
noahgift wants to merge 4 commits into
mainfrom
emr/door-split-5909-v2
Closed

noahgift wants to merge 4 commits into
mainfrom
emr/door-split-5909-v2

Conversation

@noahgift

Copy link
Copy Markdown
Member

Supersedes #6335. Built on #6334's head 715bcd4 (entry text states the dev-dependency reality). Fixes the quorum findings: the version pin is now workspace = true; the entry states why env_key stays in aprender-contracts (cannot build-depend or include!() across the package boundary; the test shared_key_crate_agrees_with_env_key_and_the_macro pins the two copies). 302 lines.

🤖 Generated with Claude Code

t and others added 4 commits October 25, 2026 08:19
… and #6309 split by ticket

PMAT-5446 covers the #5893 planted-.pv tests carried by #6309 (issue #5446: slow
contracts-cli ont4 gate tests); PMAT-5909 and PMAT-5803 take their scope from
#6294. Entries plus the regenerated aggregate only.

PMAT-Ticket: PMAT-5446
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…der-contracts keeps its own env_key.rs, the key crate is a dev-dependency (Refs #5909)

PMAT-Ticket: PMAT-5909

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…s stops build-depending on the engine (Refs #5909)

Piece 1 of the #6294 split (quorum triage-quorum-tickets-6294-6309-0718Z, one PR
per ticket). Stacked on #6334 (the PMAT-5909 entry); the 5502 and 5803 scopes
are separate PRs. aprender-contracts keeps its own env_key; the key crate is
dev-only for it.

PMAT-Ticket: PMAT-5909

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ates why env_key stays in both crates (Refs #5909)

PMAT-Ticket: PMAT-5909

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

§13.11 rung 1 — quorum shadow verdict

S13-SHADOW pr=6348 head=629d12307be1b298a1996f92910318306f1b9a18 verdict=REFUSE class=Q1 arm_rc=1

Shadow mode: this records a verdict and merges nothing. A refusal
to arm is not a block (§13 adds zero rows to §7) — the pull request is
exactly as green as it was.

@noahgift

Copy link
Copy Markdown
Member Author

quorum-review (AD-04): NOT agreed (auto_merge: checked=true was_armed=false disarmed=false)

{
 "ticket": "PMAT-5909",
 "head": "629d12307be1b298a1996f92910318306f1b9a18",
 "width": 3,
 "executor": "agy",
 "agreed": false,
 "auto_merge": {
  "checked": true,
  "was_armed": false,
  "disarmed": false,
  "note": "auto-merge not armed"
 },
 "lanes": [
  {
   "lane": 1,
   "verdict": "FAIL",
   "findings": 5
  },
  {
   "lane": 2,
   "verdict": "PASS",
   "findings": 5
  },
  {
   "lane": 3,
   "verdict": "FAIL",
   "findings": 1
  }
 ]
}

@noahgift

Copy link
Copy Markdown
Member Author

Closed per operator ruling NOAH-0718Z R2 (aprender open PRs <=10): draft with no push for over 24h, over the cap. Branch kept; reopen when its ticket resumes. Survivors: #6223, #6341, #5793 and the ready PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant