Repository navigation
Conversation
The x86_64-apple-darwin and aarch64-apple-darwin legs of nightly.yml move from GitHub's macos-latest to [self-hosted, macOS, ARM64, mini]. Linux and Windows legs are unchanged. nightly.yml runs only on schedule and workflow_dispatch, so no pull request reaches that host. A persistent mac differs from the hosted image in two ways, handled in one step guarded by endsWith(matrix.target, '-apple-darwin'): - the runner environment points CARGO_TARGET_DIR at a shared directory, and the Package step copies from target/<triple>/release, so the darwin legs set CARGO_TARGET_DIR to $GITHUB_WORKSPACE/target; - the host's ~/.rustup and ~/.cargo are shared with other work, so RUSTUP_HOME and CARGO_HOME go under the runner's tool cache. Refs #421 Pmat-Ticket: PMAT-421 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
noahgift
marked this pull request as draft
October 4, 2026 14:54
Pmat-Ticket: PMAT-421
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the two nightly darwin legs (
x86_64-apple-darwin,aarch64-apple-darwin) of.github/workflows/nightly.ymlfrom GitHub's hostedmacos-latestto the fleet's self-hosted mac:runs-on: [self-hosted, macOS, ARM64, mini](runnermini-m4). Linux and Windows legs are untouched.release.yml,lint.yml,test.ymland every push / pull_request job are untouched.Fork safety.
nightly.ymltriggers only onscheduleandworkflow_dispatch. No pull request can run it, so no fork code reaches the mac.What a persistent mac needs that the hosted image gave for free. One step, guarded by
endsWith(matrix.target, '-apple-darwin'), writes to$GITHUB_ENVbefore the toolchain is installed:CARGO_TARGET_DIR=$GITHUB_WORKSPACE/target. The runner's environment pointsCARGO_TARGET_DIRat a shared directory, and the Package step copiestarget/<triple>/release/<bin>relative to the workspace. With the override the build lands exactly where Package reads it.RUSTUP_HOME=<runner tool cache>/rustup, sodtolnay/rust-toolchainandrustup target addinstall into the runner's own cache instead of the host's shared~/.rustup.CARGO_HOME=<runner tool cache>/cargo. This job set none, so on the mac it would have used the shared~/.cargo.Non-darwin legs: the step is skipped, so they get no new variable.
actionlint .github/workflows/nightly.ymlis clean.Before merge. mini-m4 sits in a runner group that does not admit this repository yet. Changing that is an org-side step taken separately. Until it lands, these two legs would queue and be cancelled after 24 h, so this PR stays a draft.
Proof after merge.
check-activitysetshas_commits=trueon anyworkflow_dispatch, regardless of whether thenightlytag is at HEAD, so a manual dispatch builds both darwin legs.Refs #421. The issue stays open until a post-merge dispatch of nightly.yml shows both darwin legs green on mini-m4.
🤖 Generated with Claude Code