Repository navigation
fix(server): PR watch reports checks that finish before its first read - #300
Merged
Merged
Conversation
A new watch baselines its first read, so a pass found there was never reported. Report it when CI was pending at the start, like failures, and tell the agent from watch_pull_request when checks already finished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new PR watch baselines its first read and never reports a pass it finds there. When checks went green between the agent's read and that first read, the agent ended its turn and was never woken.
evaluatePullRequestWatchnow reportschecks-passedon the baseline read when CI was pending at the start, matching the failure handling from fix(server): wake when CI fails during the PR watch baseline read pingdotgg/t3code#39116.watch_pull_requestreturns anexthint when its start read finds checks already passed or failed, so the agent acts now instead of waiting for a wake that never comes.Tests: extended
pullRequestWatch.test.ts(fails on base) andPullRequestWatchService.test.ts.Claude Opus 5.5 in T3 Code (Claude Code harness).