Repository navigation
feat!: require explicit transaction opt-in on command handlers - #20
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
0 New Issues
0 Fixed Issues
4 Accepted Issues
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Command handlers opt into automatic transactions with
IRequireTransactionfromPANiXiDA.Core.Application.Persistence. Saving changes and publishing domain events remain independent of the marker.CommitTransactionBehaviorandCleanupTransactionBehaviortakeTHandleras their third generic argument. Mediator adapters must bind the actual handler type and skip transaction behaviors for unmarked handlers. Result propagation, concurrency handling, and cleanup exception semantics are preserved.The package version remains 5.1. The README contains concise usage guidance. Wolverine must support the new behavior signatures before adopting this package.
Validation:
dotnet restore,dotnet format,dotnet build --configuration Release, anddotnet test --configuration Releasepassed. Release build: 0 warnings and 0 errors. Tests: 309 passed, 0 failed, 0 skipped.