Repository navigation
feat: save unit of work changes in command behavior - #22
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5c323e1fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 similar comment
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06efc7016e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Добавляет
IUnitOfWork.SaveChangesAsyncиSaveChangesBehavior. Успешная команда сохраняет накопленные изменения после сбора доменных событий независимо от наличия активной транзакции. Если транзакция открыта, commit выполняется следующим behavior. При неуспешном результате сохранение пропускается.Версия пакета остаётся 5.1, зависимость Domain обновлена до опубликованной 4.0.1. Реализации IUnitOfWork должны реализовать SaveChangesAsync. README содержит краткое описание текущего API и порядка behaviors, без инструкций по миграции.
Проверки: restore с опубликованным Domain 4.0.1, форматирование, Release build без предупреждений и 303 успешных теста. Проверены успешные и неуспешные команды с транзакцией и без неё, передача cancellation token, отсутствие вызовов begin/commit из save behavior, исходные ошибки сохранения, конфликты и отмена. Четыре сценария без транзакции падали до исправления проверки HasActiveTransaction и теперь проходят.
Связанные адаптеры: EF #21 и Wolverine #22.