Repository navigation
OPS-157454: Upload test coverage to Codacy from CI #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,33 @@ | ||||||
| <?xml version="1.0" encoding="utf-8"?> | ||||||
| <!-- | ||||||
| Microsoft.Testing.Extensions.CodeCoverage settings. | ||||||
|
|
||||||
| The attribute exclusions are not optional if figures are to stay comparable across the estate: the | ||||||
| Microsoft collector includes generated code by default, where coverlet excluded it. Porting them is | ||||||
| worth several points of apparent coverage on a repository with generated clients. | ||||||
| --> | ||||||
| <Configuration> | ||||||
| <CodeCoverage> | ||||||
| <ModulePaths> | ||||||
| <Exclude> | ||||||
| <ModulePath>.*Test\.dll$</ModulePath> | ||||||
| <ModulePath>.*Tests\.dll$</ModulePath> | ||||||
| </Exclude> | ||||||
| </ModulePaths> | ||||||
| <Attributes> | ||||||
| <Exclude> | ||||||
| <Attribute>^System\.Diagnostics\.CodeAnalysis\.ExcludeFromCodeCoverageAttribute$</Attribute> | ||||||
| <Attribute>^System\.Runtime\.CompilerServices\.CompilerGeneratedAttribute$</Attribute> | ||||||
| <Attribute>^System\.CodeDom\.Compiler\.GeneratedCodeAttribute$</Attribute> | ||||||
| <Attribute>^System\.ObsoleteAttribute$</Attribute> | ||||||
| </Exclude> | ||||||
| </Attributes> | ||||||
| <Sources> | ||||||
| <Exclude> | ||||||
| <Source>.*\\obj\\.*</Source> | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 馃煛 MEDIUM RISK Suggestion: The path separator in the regex is Windows-specific. Since the job runs on a Linux runner ('pdl-public'), use a cross-platform pattern (e.g., forward slashes or '[/\\]') to ensure the 'obj' directory is correctly excluded. Suggested fix:
Suggested change
|
||||||
| </Exclude> | ||||||
| </Sources> | ||||||
| <UseVerifiableInstrumentation>False</UseVerifiableInstrumentation> | ||||||
| <CollectFromChildProcesses>True</CollectFromChildProcesses> | ||||||
| </CodeCoverage> | ||||||
| </Configuration> | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
馃敶 HIGH RISK
The coverage report path is likely incorrect. The 'Run tests' step uses '--coverage-output coverage.cobertura.xml' from the root, so the output will be at 'TestResults/coverage.cobertura.xml' rather than inside the bin directory. Verify the path to ensure the upload step finds the file.