Skip to content

Make the coverage.config obj exclusion match on Linux - #48

Merged
davidnmbond merged 1 commit into
mainfrom
fix/coverage-obj-pattern
Oct 3, 2026
Merged

davidnmbond merged 1 commit into
mainfrom
fix/coverage-obj-pattern

Conversation

@davidnmbond

Copy link
Copy Markdown
Contributor

The coverage.config source exclusion for obj was written with Windows-only path separators, so on our Linux CI runners it matched nothing, and source-generated files under obj/ (Refit clients, logging generators) counted towards coverage. Measured before the fix: Meraki.Api's coverage report included 29 such files, PanoramicData.OData.Client's 1.

The pattern is now .*[\\/]obj[\\/].*, which matches either separator, so it works on both the Linux runners and Windows workstations.

Tracked on OPS-157454.

🤖 Generated with Claude Code

… Windows

The obj source exclusion was written with Windows-only path separators, so on
the Linux CI runners it matched nothing, and source-generated files under obj/
(Refit clients, logging generators) were counted towards coverage. The pattern
now uses a character class matching either separator.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@codacy-production

codacy-production Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage ∅ diff coverage · +0.00% coverage variation

Metric Results
Coverage variation ✅ +0.00% coverage variation (-1.00%)
Diff coverage ✅ ∅ diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (afe6afe) 162 91 56.17%
Head commit (7608faa) 162 (+0) 91 (+0) 56.17% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#48) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

AI Reviewer: first review requested successfully. AI can make mistakes. Always validate suggestions.

Run reviewer

TIP This summary will be updated as you push new changes.

@davidnmbond
davidnmbond merged commit 79bfe10 into main Oct 3, 2026
6 checks passed
@davidnmbond
davidnmbond deleted the fix/coverage-obj-pattern branch October 3, 2026 14:49

@codacy-production codacy-production Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the coverage exclusion configuration to use a cross-platform regex for 'obj' directories, facilitating consistent coverage reporting between Windows and Linux. Codacy results indicate that the changes meet project standards with no new quality or complexity issues. The primary risk identified is the absence of verification for the regex pattern across different operating systems to ensure it correctly excludes the intended directories without affecting other paths.

About this PR

  • The transition to a cross-platform regex for directory exclusion lacks explicit verification. It is recommended to confirm that the updated pattern correctly matches both Windows ('\') and Linux ('/') separators to ensure 'obj' directories are consistently excluded across all CI environments.

Test suggestions

  • Verify the regex pattern correctly matches paths containing '/obj/' on Linux-based environments.
  • Verify the regex pattern correctly matches paths containing '\obj' on Windows-based environments.
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify the regex pattern correctly matches paths containing '/obj/' on Linux-based environments.
2. Verify the regex pattern correctly matches paths containing '\obj\' on Windows-based environments.

TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant